New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state leakage in Kramdown test #4618

Merged
merged 1 commit into from Mar 1, 2016

Conversation

Projects
None yet
3 participants
@ghost

ghost commented Mar 1, 2016

Fixes #4250, one occurence of #4617

@parkr parkr changed the title from Fix state leakage in Kramdown test (#4250) to Fix state leakage in Kramdown test Mar 1, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 1, 2016

Member

@spudowiar Almost seems too easy! Thanks! 😄 Also, for the future, we all have to work at our own pace and it may take a few days to see something through. You're welcome to merge your commits into the other branch you're working on if they do indeed fix the problem.

No Travis build was spawned for this. I'm going to run CI locally and confirm it all passes. I'll merge then.

Member

parkr commented Mar 1, 2016

@spudowiar Almost seems too easy! Thanks! 😄 Also, for the future, we all have to work at our own pace and it may take a few days to see something through. You're welcome to merge your commits into the other branch you're working on if they do indeed fix the problem.

No Travis build was spawned for this. I'm going to run CI locally and confirm it all passes. I'll merge then.

@parkr parkr added the fix label Mar 1, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 1, 2016

Member

@jekyllbot: merge +dev

Member

parkr commented Mar 1, 2016

@jekyllbot: merge +dev

jekyllbot added a commit that referenced this pull request Mar 1, 2016

@jekyllbot jekyllbot merged commit f274179 into jekyll:master Mar 1, 2016

jekyllbot added a commit that referenced this pull request Mar 1, 2016

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Mar 1, 2016

Anyway, this shouldn't be necessary. Something somewhere is enabling Pygments for all the tests and we need to fix tests like that.

ghost commented Mar 1, 2016

Anyway, this shouldn't be necessary. Something somewhere is enabling Pygments for all the tests and we need to fix tests like that.

@ghost ghost deleted the fix-test-state-leakage branch Mar 1, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Mar 1, 2016

Contributor

@spudowiar that's the plan with RSpec which I really need to finish up, it actually has a mocker for Jekyll that creates a completely clean state for each test so there is no leakage. Thanks for the fix too!

Contributor

envygeeks commented Mar 1, 2016

@spudowiar that's the plan with RSpec which I really need to finish up, it actually has a mocker for Jekyll that creates a completely clean state for each test so there is no leakage. Thanks for the fix too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment