New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuous-integration docs with sudo: false information #4628

Merged
merged 1 commit into from Mar 9, 2016

Conversation

Projects
None yet
4 participants
@mejackreed
Contributor

mejackreed commented Mar 3, 2016

Updates the continuous-integration docs to provide information about the sudo: false behavior which can route builds to the faster container-based infrastructure. https://docs.travis-ci.com/user/workers/container-based-infrastructure/#Routing-your-build-to-container-based-infrastructure

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Mar 8, 2016

Member

I like this idea, but I think it makes more sense to just have sudo: false be the default instead of pointing it out as an option.

Could you switch the language in the docs around to default to sudo: false and then explain how to enable sudo if something fails?

Member

mattr- commented Mar 8, 2016

I like this idea, but I think it makes more sense to just have sudo: false be the default instead of pointing it out as an option.

Could you switch the language in the docs around to default to sudo: false and then explain how to enable sudo if something fails?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 9, 2016

Member

Could you switch the language in the docs around to default to sudo: false and then explain how to enable sudo if something fails?

☝️ Yes please!

Also, @mattr-, you can use @jekyllbot to merge when you're ready. 😄 I just added better auth so that anyone who has push access to a repo can use jekyllbot to merge.

Member

parkr commented Mar 9, 2016

Could you switch the language in the docs around to default to sudo: false and then explain how to enable sudo if something fails?

☝️ Yes please!

Also, @mattr-, you can use @jekyllbot to merge when you're ready. 😄 I just added better auth so that anyone who has push access to a repo can use jekyllbot to merge.

@parkr parkr added the documentation label Mar 9, 2016

@mejackreed

This comment has been minimized.

Show comment
Hide comment
@mejackreed

mejackreed Mar 9, 2016

Contributor

Thanks for your feedback! I've modified the language in the following way:

  • removed "optional" from the example travis.yml configuration
  • Added "By default you should supply the sudo: false command to Travis."
  • Added "If you have any trouble with your build, or if your build does need sudo access, remove the sudo:false line."

I amended the commit and pushed it up. Let me know if you would like anything else changed.

Contributor

mejackreed commented Mar 9, 2016

Thanks for your feedback! I've modified the language in the following way:

  • removed "optional" from the example travis.yml configuration
  • Added "By default you should supply the sudo: false command to Travis."
  • Added "If you have any trouble with your build, or if your build does need sudo access, remove the sudo:false line."

I amended the commit and pushed it up. Let me know if you would like anything else changed.

Update continuous-integration docs with sudo: false information
Updates the continuous-integration docs to provide information about the `sudo: false` behavior which can route builds to the faster container-based infrastructure. https://docs.travis-ci.com/user/workers/container-based-infrastructure/#Routing-your-build-to-container-based-infrastructure
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 9, 2016

Member

❤️

@jekyllbot: merge +site

Member

parkr commented Mar 9, 2016

❤️

@jekyllbot: merge +site

jekyllbot added a commit that referenced this pull request Mar 9, 2016

@jekyllbot jekyllbot merged commit 9e57eb1 into jekyll:master Mar 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 9, 2016

@mejackreed mejackreed deleted the mejackreed:travis-sudo branch Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment