Added a default lang attribute #4633

Merged
merged 1 commit into from Mar 4, 2016

Conversation

Projects
None yet
3 participants
@HugoGiraudel
Contributor

HugoGiraudel commented Mar 4, 2016

Omitting the lang attribute is an accessibility concern, and given how popular Jekyll is I thought it would be a good idea to set a default lang attribute to the html element. I went with en as I figured out it would be a meaningful default.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Mar 4, 2016

Contributor

@jekyllbot merge +site

Contributor

envygeeks commented Mar 4, 2016

@jekyllbot merge +site

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Mar 4, 2016

Contributor

ah boo he doesn't listen to me yet.

Contributor

envygeeks commented Mar 4, 2016

ah boo he doesn't listen to me yet.

envygeeks added a commit that referenced this pull request Mar 4, 2016

Merge pull request #4633 from HugoGiraudel/patch-1
Added a default lang attribute

@envygeeks envygeeks merged commit 03f57a8 into jekyll:master Mar 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Mar 4, 2016

Contributor

❤️

Contributor

envygeeks commented Mar 4, 2016

❤️

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Mar 4, 2016

Contributor

Wow, is it that easy to update the default Jekyll template? I’ll come back. :D

Contributor

HugoGiraudel commented Mar 4, 2016

Wow, is it that easy to update the default Jekyll template? I’ll come back. :D

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 10, 2016

Member

@envygeeks you need a colon after @jekyllbot's name. kinda strict on purpose 😉

Member

parkr commented Mar 10, 2016

@envygeeks you need a colon after @jekyllbot's name. kinda strict on purpose 😉

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 10, 2016

Member

@HugoGiraudel This is not necessarily the case, I don't think this should be a part of the default. If anything, it should be {{ site.lang }} and add lang to the _config.yml. A lot of people use this template to write in all sorts of languages, so hard-coding this would be lying to the interwebs!

Member

parkr commented Mar 10, 2016

@HugoGiraudel This is not necessarily the case, I don't think this should be a part of the default. If anything, it should be {{ site.lang }} and add lang to the _config.yml. A lot of people use this template to write in all sorts of languages, so hard-coding this would be lying to the interwebs!

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Mar 10, 2016

Contributor

If anything, it should be {{ site.lang }} and add lang to the _config.yml.

That is a very good idea. A very good idea indeed. Sorry I did not think of it in the first place. Let’s do that instead.

Contributor

HugoGiraudel commented Mar 10, 2016

If anything, it should be {{ site.lang }} and add lang to the _config.yml.

That is a very good idea. A very good idea indeed. Sorry I did not think of it in the first place. Let’s do that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment