Fixes typo on collections #4647

Merged
merged 1 commit into from Mar 11, 2016

Conversation

Projects
None yet
3 participants
@gesa
Contributor

gesa commented Mar 10, 2016

There was a line referring to the render key in _config.yml but the actual name of the key is output.

site/_docs/collections.md
@@ -305,7 +305,7 @@ file, each document has the following attributes:
<p>
The URL of the rendered collection. The file is only written to the
destination when the name of the collection to which it belongs is
- included in the <code>render</code> key in the site's configuration
+ included in the <code>output</code> key in the site's configuration

This comment has been minimized.

@parkr

parkr Mar 11, 2016

Member

I guess this whole paragraph is wrong. What about:

The URL of the rendered collection. The file is only written to the destination when the collection to which it belongs has output: true in the site's configuration.

@parkr

parkr Mar 11, 2016

Member

I guess this whole paragraph is wrong. What about:

The URL of the rendered collection. The file is only written to the destination when the collection to which it belongs has output: true in the site's configuration.

@gesa

This comment has been minimized.

Show comment
Hide comment
@gesa

gesa Mar 11, 2016

Contributor

@parkr you're absolutely right. thanks for the note, updated now.

Contributor

gesa commented Mar 11, 2016

@parkr you're absolutely right. thanks for the note, updated now.

@parkr parkr removed the pending-feedback label Mar 11, 2016

site/_docs/collections.md
- included in the <code>render</code> key in the site's configuration
- file.
- </p>
+ The URL of the rendered collection. The file is only written to the destination when the collection to which it belongs has `output: true` in the site's configuration.

This comment has been minimized.

@parkr

parkr Mar 11, 2016

Member

Unfortunately the backticks won't work here. Could you use <code>output: true</code> instead?

@parkr

parkr Mar 11, 2016

Member

Unfortunately the backticks won't work here. Could you use <code>output: true</code> instead?

This comment has been minimized.

@gesa

gesa Mar 11, 2016

Contributor

shit, i'm sorry. habits die hard. updated now!

@gesa

gesa Mar 11, 2016

Contributor

shit, i'm sorry. habits die hard. updated now!

Fixes typo on collections
There was a line referring to the `render` key in `_config.yml` but the actual name of the key is `output`.

Thank you, @parkr!

@parkr parkr removed the pending-feedback label Mar 11, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 11, 2016

Member

Thanks so much! ❤️

@jekyllbot: merge +site

Member

parkr commented Mar 11, 2016

Thanks so much! ❤️

@jekyllbot: merge +site

jekyllbot added a commit that referenced this pull request Mar 11, 2016

@jekyllbot jekyllbot merged commit 204e307 into jekyll:master Mar 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment