New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'jekyll clean': also remove .sass-cache #4652

Merged
merged 1 commit into from Mar 11, 2016

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Mar 11, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Mar 11, 2016

Contributor

Hash Rocket.

Contributor

envygeeks commented on lib/jekyll/commands/clean.rb in 79f8210 Mar 11, 2016

Hash Rocket.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 11, 2016

Member

@envygeeks I think your bot thinks named parameters are a hash? Or can I not use named parameters?

Member

parkr commented Mar 11, 2016

@envygeeks I think your bot thinks named parameters are a hash? Or can I not use named parameters?

@ctubbsii

This comment has been minimized.

Show comment
Hide comment
@ctubbsii

ctubbsii commented Mar 11, 2016

+1 LGTM

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Mar 11, 2016

Contributor

@parkr The bot has no real way to distinguish between keyword arguments and hashes because it's hard without us building more context driven detection.

Contributor

envygeeks commented Mar 11, 2016

@parkr The bot has no real way to distinguish between keyword arguments and hashes because it's hard without us building more context driven detection.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 11, 2016

Member

@jekyllbot: merge +minor

Member

parkr commented Mar 11, 2016

@jekyllbot: merge +minor

jekyllbot added a commit that referenced this pull request Mar 11, 2016

@jekyllbot jekyllbot merged commit d4c1d97 into master Mar 11, 2016

1 of 3 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the clean-sass-cache branch Mar 11, 2016

jekyllbot added a commit that referenced this pull request Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment