Don't blindly assume the last system when determining "open" cmd #4717

Merged
merged 1 commit into from Apr 1, 2016

Conversation

Projects
None yet
3 participants
@envygeeks
Contributor

envygeeks commented Mar 28, 2016

As it was we assumed that any system that wasn't Windows or OS X must be Linux
but the reality of that can be very unlikely. BSD is popular in some places and
it's not Linux and this would cause an error there. If we do not know the
launcher for a platform we should ship an error and have the user file
a bug if they feel it necessary and skip the launch otherwise.

Don't blindly assume the last-system.
As it was we assumed that any system that wasn't Windows or OS X must be Linux
but the reality of that can be very unlikely. BSD is popular in some places and
it's not Linux and this would cause an error there.  If we do not know the
launcher for a platform we should ship an error and have the user file
a bug if they feel it necessary and skip the launch otherwise.

@parkr parkr changed the title from Don't blindly assume the last-system. to Don't blindly assume the last system when determining "open" cmd Apr 1, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 1, 2016

Member

👍

@jekyllbot: merge +dev

Member

parkr commented Apr 1, 2016

👍

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit a224491 into master Apr 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the cleanup-launch-browser branch Apr 1, 2016

jekyllbot added a commit that referenced this pull request Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment