Globalize Jekyll's Filters. #4792

Merged
merged 2 commits into from Apr 20, 2016

Conversation

Projects
None yet
5 participants
@envygeeks
Contributor

envygeeks commented Apr 15, 2016

As it stands Jekyll does not globalize it's filters. So anybody wishing to go
into Jekyll's context to process their own Liquid (say in a plugin) may be taken
aback when they find out that Jekyll's filters are not available.
See: envygeeks/jekyll-assets#252.

/cc @jekyll/core @jekyll/stability

Globalize Jekyll's Filters.
As it stands Jekyll does not globalize it's filters.  So anybody wishing to go
into Jekyll's context to process their own Liquid (say in a plugin) may be taken
aback when they find out that Jekyll's filters are not available.
See: envygeeks/jekyll-assets#252.
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 15, 2016

Contributor

/cc @2474

Contributor

envygeeks commented Apr 15, 2016

/cc @2474

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 15, 2016

Member

@envygeeks Great idea! This seems to have broken the cucumber tests though... know what's going on there?

Member

parkr commented Apr 15, 2016

@envygeeks Great idea! This seems to have broken the cucumber tests though... know what's going on there?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 15, 2016

Contributor

@parkr looking into it now.

Contributor

envygeeks commented Apr 15, 2016

@parkr looking into it now.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 15, 2016

Contributor

Should be ready to 🚢 now. I forgot to make the filters explicit instead of implicit.

Contributor

envygeeks commented Apr 15, 2016

Should be ready to 🚢 now. I forgot to make the filters explicit instead of implicit.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Apr 15, 2016

Member

Is this going to affect plugins that have been manually registering Jekyll’s filters?

Context: https://github.com/jekyll/jekyll-seo-tag/blob/master/lib/jekyll-seo-tag.rb#L44

Member

pathawks commented Apr 15, 2016

Is this going to affect plugins that have been manually registering Jekyll’s filters?

Context: https://github.com/jekyll/jekyll-seo-tag/blob/master/lib/jekyll-seo-tag.rb#L44

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 15, 2016

Contributor

@pathawks it won't. Their explicit re-inclusion will just overwrite with the same methods locally.

Contributor

envygeeks commented Apr 15, 2016

@pathawks it won't. Their explicit re-inclusion will just overwrite with the same methods locally.

@2474

This comment has been minimized.

Show comment
Hide comment
@2474

2474 Apr 15, 2016

@envygeeks Thanks for doing this work. I appreciate your help.

2474 commented Apr 15, 2016

@envygeeks Thanks for doing this work. I appreciate your help.

@parkr parkr added this to the 3.2 milestone Apr 20, 2016

@parkr parkr added the bug label Apr 20, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 20, 2016

Member

@jekyllbot: merge +minor

Member

parkr commented Apr 20, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 341407e into master Apr 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the feature/globalize-filters branch Apr 20, 2016

jekyllbot added a commit that referenced this pull request Apr 20, 2016

@parkr parkr added enhancement and removed bug labels Apr 20, 2016

parkr added a commit that referenced this pull request Apr 21, 2016

Merge branch 'master' into themes
* master: (58 commits)
  Update history to reflect merge of #4792 [ci skip]
  Update history to reflect merge of #4793 [ci skip]
  Update history to reflect merge of #4804 [ci skip]
  Update history to reflect merge of #4754 [ci skip]
  Update history to reflect merge of #4813 [ci skip]
  Added missing single quote on rsync client side command
  Add v3.0.4 and v3.1.3 to the history.
  Fixed typo
  Add jekyll-autoprefixer plugin
  Explicitly require Filters rather than implicitly.
  Update history to reflect merge of #4786 [ci skip]
  Update history to reflect merge of #4789 [ci skip]
  updates example domain in config template
  Globalize Jekyll's Filters.
  Update JRuby to 9.0.5.0; Drop the double digit test.
  Update Rack-Jekyll Heroku deployment blog post url
  convertible: use Document::YAML_FRONT_MATTER_REGEXP to parse transformable files
  Update history to reflect merge of #4734 [ci skip]
  Update history to reflect merge of #4478 [ci skip]
  Fix rubocop warning.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment