Example in the site template should be IANA-approved example.com #4793

Merged
merged 1 commit into from Apr 20, 2016

Conversation

Projects
None yet
5 participants
@sl4m
Contributor

sl4m commented Apr 15, 2016

yourdomain(dot)com is a deceptive website. If a jekyll user does not change this in their config, they will default to this website and it appears in places like the RSS feed. I've just experienced this with another jekyll user's blog.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 15, 2016

Contributor

/cc @benbalter @parkr
This should be merged and maybe Github should do a check?

Contributor

envygeeks commented Apr 15, 2016

/cc @benbalter @parkr
This should be merged and maybe Github should do a check?

@sl4m

This comment has been minimized.

Show comment
Hide comment
@sl4m

sl4m Apr 15, 2016

Contributor

I'm sure GitHub staff can do a much better job searching, but here are results I pulled from GitHub search. Over 13k public repositories with references to the bad domain.

https://github.com/search?utf8=%E2%9C%93&q=http%3A%2F%2Fyourdomain.com+extension%3Ayml&type=Code&ref=advsearch&l=&l=

Contributor

sl4m commented Apr 15, 2016

I'm sure GitHub staff can do a much better job searching, but here are results I pulled from GitHub search. Over 13k public repositories with references to the bad domain.

https://github.com/search?utf8=%E2%9C%93&q=http%3A%2F%2Fyourdomain.com+extension%3Ayml&type=Code&ref=advsearch&l=&l=

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 15, 2016

Member

What do you think about commenting it out to prevent this?

Member

parkr commented Apr 15, 2016

What do you think about commenting it out to prevent this?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 15, 2016

Contributor

IMO example.com might be the route to go since it's the IANA domain for example domains. It's owned by IANA, is reserved by IANA and it (along with a dozen other domains) suite to serve as url's for apps to use without being taken (like the current example demonstrates.)

Contributor

envygeeks commented Apr 15, 2016

IMO example.com might be the route to go since it's the IANA domain for example domains. It's owned by IANA, is reserved by IANA and it (along with a dozen other domains) suite to serve as url's for apps to use without being taken (like the current example demonstrates.)

@parkr parkr changed the title from Updates example domain in config template to Example in the site template should be IANA-approved example.com Apr 20, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 20, 2016

Member

Sounds good to me!

@jekyllbot: merge +bug

Member

parkr commented Apr 20, 2016

Sounds good to me!

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 46b2ab8 into jekyll:master Apr 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Apr 20, 2016

parkr added a commit that referenced this pull request Apr 21, 2016

Merge branch 'master' into themes
* master: (58 commits)
  Update history to reflect merge of #4792 [ci skip]
  Update history to reflect merge of #4793 [ci skip]
  Update history to reflect merge of #4804 [ci skip]
  Update history to reflect merge of #4754 [ci skip]
  Update history to reflect merge of #4813 [ci skip]
  Added missing single quote on rsync client side command
  Add v3.0.4 and v3.1.3 to the history.
  Fixed typo
  Add jekyll-autoprefixer plugin
  Explicitly require Filters rather than implicitly.
  Update history to reflect merge of #4786 [ci skip]
  Update history to reflect merge of #4789 [ci skip]
  updates example domain in config template
  Globalize Jekyll's Filters.
  Update JRuby to 9.0.5.0; Drop the double digit test.
  Update Rack-Jekyll Heroku deployment blog post url
  convertible: use Document::YAML_FRONT_MATTER_REGEXP to parse transformable files
  Update history to reflect merge of #4734 [ci skip]
  Update history to reflect merge of #4478 [ci skip]
  Fix rubocop warning.
  ...
@georgiee

This comment has been minimized.

Show comment
Hide comment
@georgiee

georgiee May 24, 2016

Thanks for this.

yourdomain.com was a really bad choice. The owner serves a lot of ads and potentially malicious content under the domain. The site yourdomain.com also forces a redirects of the parent window - which is why my fresh jekyll installation just redirected me to an ad 🤔 I was using the innocent looking {{site.url}} (filed with yourdomain.com inn the latest release) in combination with an iframe. Bad luck I guess.

I came here to propose a change to the official example.com domain and found that it was already done. Good job 👍

Thanks for this.

yourdomain.com was a really bad choice. The owner serves a lot of ads and potentially malicious content under the domain. The site yourdomain.com also forces a redirects of the parent window - which is why my fresh jekyll installation just redirected me to an ad 🤔 I was using the innocent looking {{site.url}} (filed with yourdomain.com inn the latest release) in combination with an iframe. Bad luck I guess.

I came here to propose a change to the official example.com domain and found that it was already done. Good job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment