Remove call to #backwards_compatibilize in Configuration.from #4846

Merged
merged 1 commit into from Apr 27, 2016

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Apr 27, 2016

In Jekyll 3.0.4, using the --watch flag doesn't work. The way configurations are read using Jekyll.configuration, Configuration#backwards_compatibilize is called on the flag input as well as the file input. It's only meant to be applied to the file input. A call is made in Configuration#read_config_files so we'll leave that as the only place it should be called.

Tested on my site https://byparker.com and it regenerates as expected. 馃憤

Fixes #4831. 馃檹

Targets v3.0.4 for a v3.0.5 release.

/cc @jekyll/stability @jekyll/gh-pages

@parkr parkr added this to the 3.0.5 milestone Apr 27, 2016

@parkr parkr added bug fix labels Apr 27, 2016

@parkr parkr self-assigned this Apr 27, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 27, 2016

Contributor

LGTM. You want me to have Hulk pull it down and test it?

Contributor

envygeeks commented Apr 27, 2016

LGTM. You want me to have Hulk pull it down and test it?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 27, 2016

Member

You want me to have Hulk pull it down and test it?

Sure, if you want to!

Member

parkr commented Apr 27, 2016

You want me to have Hulk pull it down and test it?

Sure, if you want to!

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 27, 2016

Contributor

Hulk: test recipe:jekyll ++local ++folder:site/

Contributor

envygeeks commented Apr 27, 2016

Hulk: test recipe:jekyll ++local ++folder:site/

@parkr parkr merged commit 30e7123 into 3.0-stable Apr 27, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@parkr parkr deleted the fix-multiple-backwards-compatibilizes branch Apr 27, 2016

@perlun

This comment has been minimized.

Show comment
Hide comment
@perlun

perlun Apr 27, 2016

Awesome, thanks a lot for the fix!

perlun commented Apr 27, 2016

Awesome, thanks a lot for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment