Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add 'jekyll new-theme' command to help users get up and running creating a theme #4848
This may be a terrible idea, but what about
Alternatively, borrowing from
Do you think there could be more options related to theme management in the future?
May 20, 2016
1 check passed
added a commit
this pull request
May 20, 2016
@parkr Nice work. Ran things locally, and everything worked as expected, but had some feedback on the experience and on the defaults:
How is this used? I remember there was a discussion about this when the feature was originally proposed, but depending on its use, wondering if we should namespace things in a
When would a theme have an executable? (From the default gemspec)
Unless I'm misreading, we want to include layouts/includes/sass, the gemspec and exclude everything else (including exe). (A) I don't think this line accomplishes what we want right now, and (B) I'm wondering if we should default to a whitelist to encourage stronger defaults.
This feels super heavyweight to me, and given that we have no way to e.g., distribute bug fixes to themes, I think we're setting ourselves up for heartbreak and failure "To fix this issue, copy and paste this Gist into your theme's Rakefile"
I'm not sure the
One other thing to note, we may not want to add a code of conduct by default. Having a code of conduct that the author doesn't have any intention to support could send the wrong signal... that those codes of conduct are intended to protect should contribute to this project (thinking it's safe and that they'd be protected), when in fact, that's not true.
I'd definitely be in favor of a