New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rescue LoadError or bundler load errors for Bundler. #4857

Merged
merged 1 commit into from Apr 29, 2016

Conversation

Projects
None yet
3 participants
@envygeeks
Contributor

envygeeks commented Apr 29, 2016

When it comes to bundler it's smart enough to know what to require, and in casees it's not, it's smart enough to accept :require. In most cases when bundler has a LoadError (or otherwise) it's because there is a problem inside of the Gem itself and when this happens, Jekyll will happily let that error slip when it shouldn't, resulting in a badly placed error that is actually wrong. This corrects that so errors can surface properly.

Fix #4856: Don't rescue LoadError or bundler load errors for Bundler.
When it comes to bundler it's smart enough to know what to require, and in casees it's not, it's smart enough to accept :require.  In most cases when bundler has a LoadError (or otherwise) it's because there is a problem inside of the Gem itself and when this happens, Jekyll will happily let that error slip when it shouldn't, resulting in a badly placed error that is actually wrong. This corrects that so errors can surface properly.

@envygeeks envygeeks changed the title from Fix #4856: Don't rescue LoadError or bundler load errors for Bundler. to Don't rescue LoadError or bundler load errors for Bundler. Apr 29, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 29, 2016

Member

LGTM.

@jekyllbot: merge +bug

Member

parkr commented Apr 29, 2016

LGTM.

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 6c08142 into master Apr 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Apr 29, 2016

@jekyllbot jekyllbot deleted the fix/dont-rescue-load-error-for-bundler branch Apr 29, 2016

jekyllbot added a commit that referenced this pull request Apr 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment