Cleaning up site template & theme updates. #4922

Merged
merged 9 commits into from Jun 17, 2016

Conversation

Projects
None yet
5 participants
@parkr
Member

parkr commented May 21, 2016

  • Theme template example should link to the post, not just quote it
  • Add .gitignore for .bundle, Gemfile.lock, .sass-cache/, etc.
  • Maybe lock gemspec to 3.2 or greater? Just use whatever version of Jekyll the user is running
  • Migrate existing site template to use a theme

/cc @jekyll/ecosystem, anything else you can think of to improve this? Check out the current incarnation in Jekyll v3.2.0.pre.beta1. 馃槃 Just run jekyll new-theme <theme-name> and see what's inside!

@parkr parkr added the enhancement label May 21, 2016

@parkr parkr added this to the 3.2 milestone May 21, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 21, 2016

Contributor

Where are the files going?

Contributor

envygeeks commented May 21, 2016

Where are the files going?

@SuriyaaKudoIsc

This comment has been minimized.

Show comment
Hide comment
@SuriyaaKudoIsc

SuriyaaKudoIsc May 22, 2016

Member

Jekyll commands and the system doesn't work correctly: #4928!

Member

SuriyaaKudoIsc commented May 22, 2016

Jekyll commands and the system doesn't work correctly: #4928!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 23, 2016

Member

@SuriyaaKudoIsc #4928 is for our site, jekyllrb.com. This pull request is for our theme template for new themes.

Member

parkr commented May 23, 2016

@SuriyaaKudoIsc #4928 is for our site, jekyllrb.com. This pull request is for our theme template for new themes.

@SuriyaaKudoIsc

This comment has been minimized.

Show comment
Hide comment
@SuriyaaKudoIsc

SuriyaaKudoIsc May 23, 2016

Member

Oh, I see.

Member

SuriyaaKudoIsc commented May 23, 2016

Oh, I see.

@parkr parkr referenced this pull request May 23, 2016

Closed

Release Jekyll v3.2 #4891

12 of 12 tasks complete

parkr added some commits Jun 14, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 14, 2016

Member

This is ready. Can I have some 馃憖 on it? @benbalter, especially. 鉂わ笍

Member

parkr commented Jun 14, 2016

This is ready. Can I have some 馃憖 on it? @benbalter, especially. 鉂わ笍

@@ -5,7 +5,7 @@
Lorem ipsum dolor sit amet, quo id prima corrumpit pertinacia, id ius dolor dolores, an veri pertinax explicari mea. Agam solum et qui, his id ludus graeco adipiscing. Duis theophrastus nam in, at his vidisse atomorum. Tantas gloriatur scripserit ne eos. Est wisi tempor habemus at, ei graeco dissentiet eos. Ne usu aliquip sanctus conceptam, te vis ignota animal, modus latine contentiones ius te.

This comment has been minimized.

@benbalter

benbalter Jun 15, 2016

Contributor

Should the index have a default or page layout (so that it renders with the theme)?

@benbalter

benbalter Jun 15, 2016

Contributor

Should the index have a default or page layout (so that it renders with the theme)?

This comment has been minimized.

@parkr

parkr Jun 15, 2016

Member

I have a comment above that says # Specify a layout from your theme! so users don't feel confined to default or page or whatever. Should we just choose one anyway?

@parkr

parkr Jun 15, 2016

Member

I have a comment above that says # Specify a layout from your theme! so users don't feel confined to default or page or whatever. Should we just choose one anyway?

This comment has been minimized.

@benbalter

benbalter Jun 15, 2016

Contributor

I'm just thinking that we're initializing it with a theme, but when you view the site, it'll be unthemed out of the box.

@benbalter

benbalter Jun 15, 2016

Contributor

I'm just thinking that we're initializing it with a theme, but when you view the site, it'll be unthemed out of the box.

This comment has been minimized.

@parkr

parkr Jun 15, 2016

Member

Done.

@parkr

parkr Jun 15, 2016

Member

Done.

parkr added some commits Jun 15, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 17, 2016

Member

@jekyllbot: merge +minor

Member

parkr commented Jun 17, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 7ee99bc into master Jun 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the jekyll-new-use-theme branch Jun 17, 2016

jekyllbot added a commit that referenced this pull request Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment