New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From v3.1.5: Sort the results of the require_all glob #4944

Merged
merged 2 commits into from May 25, 2016

Conversation

Projects
None yet
4 participants
@pathawks
Member

pathawks commented May 25, 2016

Merge #4912 into master
#4911

parkr added some commits May 19, 2016

Sort the results of the require_all glob.
Filesystems behave differently when performing glob listings.

In my environment, they are listed alphabetically. On my Mac, when asking for a list of files in a directory, those files are returned as a nicely sorted list. Alphabetized, like you'd want them to be. Like you'd expect them to be.

In some environments, quite different from my own, the return of a similar operation is quite random. Perhaps q comes before a, or e before d; the filesystem will choose its order of the day and you, the fare user, tired and weary from work, must bare the brunt of this.

And so, with this commit, I do hereby request that the noble makers of Dir[] provide for us, the downtrodden and ravaged users, some consistency. As a user of Ruby, I shouldn't have to know or consider the behaviour of an individual filesystem here; it should function the same for all filesystems.

Truly yours,
Parker
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 25, 2016

Contributor

:shipit:

Contributor

envygeeks commented May 25, 2016

:shipit:

@envygeeks envygeeks added the shipit label May 25, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 25, 2016

Member

Awwww yeeessss!!!!!!!!

@jekyllbot: merge +port

Member

parkr commented May 25, 2016

Awwww yeeessss!!!!!!!!

@jekyllbot: merge +port

@jekyllbot jekyllbot merged commit dc5fd15 into jekyll:master May 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request May 25, 2016

@parkr parkr changed the title from Forward-port: Sort the results of the require_all glob to From v3.1.5: Sort the results of the require_all glob May 25, 2016

@parkr parkr added this to the 3.2 milestone May 25, 2016

@parkr parkr referenced this pull request May 25, 2016

Closed

Port changes in v3.1.4 & v3.1.5 & v3.1.6 forward #4911

8 of 8 tasks complete

parkr added a commit that referenced this pull request May 25, 2016

Merge branch 'master' into pathawks-fp/jsonify-drops
* master: (38 commits)
  Mention where it came from. [ci skip]
  Update history to reflect merge of #4944 [ci skip]
  Update history to reflect merge of #4943 [ci skip]
  Mention where it came from. [ci skip]
  Update history to reflect merge of #4942 [ci skip]
  Update history to reflect merge of #4941
  External: remove &block arg, use block_given?
  Update history to reflect merge of #4936 [ci skip]
  lib/jekyll.rb: require document_drop to ease our pain
  Sort the results of the require_all glob.
  Rubocop fixes
  Reset {{ layout }} between each render & merge layout data properly
  Add failing test for layout data inheritance bug (#4433)
  Add failing test for layout bug (#4897)
  Fix tests for plugins in configuration.
  Define Drop#each so we can use the new frozen/duping behavior
  Don't default 'include' and 'exclude' to an empty array
  Fix some minor things in the tests
  Freeze configuration defaults & duplicate in deep_merge_hashes if need be.
  Remove merge conflicts I forgot to fix.
  ...

@pathawks pathawks deleted the pathawks:fp/sort-includes branch May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment