New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdownify and smartify should convert input to string before conversion #4958

Merged
merged 2 commits into from Jun 2, 2016

Conversation

Projects
None yet
4 participants
@pathawks
Member

pathawks commented May 28, 2016

If I have a page with the following front matter:

layout: default
title: 404

and a layout called _layouts/default.html with the following contents:

{{ page.title | markdownify }}

Jekyll will fail to build the site, throwing the error:

NoMethodError: undefined method `gsub' for 404:Fixnum
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks May 28, 2016

Member

Thank you, @jekyllbot, for removing a label that didn't exist every time I force push 😜

Member

pathawks commented May 28, 2016

Thank you, @jekyllbot, for removing a label that didn't exist every time I force push 😜

@pathawks pathawks changed the title from Failing test: markdownify a number to markdownify and smartify should convert input to string before conversion May 28, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 28, 2016

Contributor

Hulk here,

It looks like @jekyllbot doesn't feel like responding to you. So let me say "you're welcome" on it's behalf.

Contributor

envygeeks commented May 28, 2016

Hulk here,

It looks like @jekyllbot doesn't feel like responding to you. So let me say "you're welcome" on it's behalf.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 28, 2016

Contributor

Pretty sure you just got trolled by my bot accidentally. Can't tell. I kid I kid, the bot doesn't know the difference, it was just trying to be nice but it did it wrong.

Contributor

envygeeks commented May 28, 2016

Pretty sure you just got trolled by my bot accidentally. Can't tell. I kid I kid, the bot doesn't know the difference, it was just trying to be nice but it did it wrong.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks May 28, 2016

Member

Even though there is a green checkmark next to my "Failing test" I can assure you that it does indeed fail. I forgot that I need to let Travis run all the tests on the failing commit before I push the fix.

Member

pathawks commented May 28, 2016

Even though there is a green checkmark next to my "Failing test" I can assure you that it does indeed fail. I forgot that I need to let Travis run all the tests on the failing commit before I push the fix.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 2, 2016

Contributor

@jekyllbot: merge +dev

Contributor

envygeeks commented Jun 2, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit e367f13 into jekyll:master Jun 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 2, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 2, 2016

Contributor

I think I did that wrong? /cc @parkr

Contributor

envygeeks commented Jun 2, 2016

I think I did that wrong? /cc @parkr

envygeeks added a commit that referenced this pull request Jun 2, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 2, 2016

Member

@envygeeks That's right! Use +major, +minor, +bug, +site, or +dev. This would be a +bug from my perspective.

Member

parkr commented Jun 2, 2016

@envygeeks That's right! Use +major, +minor, +bug, +site, or +dev. This would be a +bug from my perspective.

@pathawks pathawks deleted the pathawks:markdownify-to_s branch Jun 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment