Rubocop: jekyll/lib/site.rb #4973

Merged
merged 1 commit into from Jun 6, 2016

Conversation

Projects
None yet
5 participants
@ayastreb
Contributor

ayastreb commented Jun 1, 2016

#4885

Code style fixes in site.rb

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 2, 2016

Contributor

:shipit:

Contributor

envygeeks commented Jun 2, 2016

:shipit:

@envygeeks envygeeks added the shipit label Jun 2, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 2, 2016

Contributor

/cc @jekyll/core - This needs another set of eyes since it's more than simple changes.

Contributor

envygeeks commented Jun 2, 2016

/cc @jekyll/core - This needs another set of eyes since it's more than simple changes.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 6, 2016

Contributor

hey @parkr, @pathawks, @mattr- or anybody on @jekyll/core want to double review this so we can merge?

Contributor

envygeeks commented Jun 6, 2016

hey @parkr, @pathawks, @mattr- or anybody on @jekyll/core want to double review this so we can merge?

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jun 6, 2016

Member

looking.

Member

mattr- commented Jun 6, 2016

looking.

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jun 6, 2016

Member

I've been away for awhile and so if this is the agreed upon style, then let's :shipit:

Member

mattr- commented Jun 6, 2016

I've been away for awhile and so if this is the agreed upon style, then let's :shipit:

@envygeeks envygeeks changed the title from rubocop: jekyll/lib/site.rb to Rubocop: jekyll/lib/site.rb Jun 6, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 6, 2016

Contributor

@jekyllbot: merge +dev

Contributor

envygeeks commented Jun 6, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 7197028 into jekyll:master Jun 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 6, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 6, 2016

Contributor

❤️

Contributor

envygeeks commented Jun 6, 2016

❤️

@@ -34,7 +33,7 @@ Lint/UselessAccessModifier:
Metrics/AbcSize:
Max: 20
Metrics/ClassLength:
- Max: 240
+ Max: 300

This comment has been minimized.

@pathawks

pathawks Jun 6, 2016

Member

Is this ok?

@pathawks

pathawks Jun 6, 2016

Member

Is this ok?

This comment has been minimized.

@envygeeks

envygeeks Jun 6, 2016

Contributor

@pathawks yup, that was something I explicitly asked for, it might have been in another pull request but I do remember explicitly asking for it to change if it was a problem.

@envygeeks

envygeeks Jun 6, 2016

Contributor

@pathawks yup, that was something I explicitly asked for, it might have been in another pull request but I do remember explicitly asking for it to change if it was a problem.

This comment has been minimized.

@envygeeks

envygeeks Jun 6, 2016

Contributor

Here it is for the record: #4960 (comment)

@envygeeks

envygeeks Jun 6, 2016

Contributor

Here it is for the record: #4960 (comment)

@parkr parkr referenced this pull request Jun 15, 2016

Closed

Make jekyll/jekyll code compliant with rubocop rules #4885

114 of 115 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment