New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate HTTP response header field name #4976

Merged
merged 2 commits into from Jun 3, 2016

Conversation

Projects
None yet
3 participants
@galopin
Contributor

galopin commented Jun 2, 2016

Custom WEBrick headers default settings documentation is incorrect.

“We only provide one default and that’s a Content-Type header that disables caching in development […]”

should read:

“We only provide one default and that’s a Cache-Control header that disables caching in development […]”

Cf. https://github.com/jekyll/jekyll/blob/master/lib/jekyll/commands/serve/servlet.rb#L8-9

Fix inaccurate HTTP response header field name
§ Custom WEBrick headers default settings
Cf. ./lib/jekyll/commands/serve/servlet.rb
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 2, 2016

Contributor

@galopin actually that is correct to an extent, it's correct in that we do provide Content-Type, but it's not right that we only provide it, we actually provide by default Content-Type _and_ Cache-Control, one dynamic, the other static: https://github.com/jekyll/jekyll/blob/master/lib/jekyll/commands/serve/servlet.rb#L40

Do you mind updating the pull request to reflect that?
Thanks!

Contributor

envygeeks commented Jun 2, 2016

@galopin actually that is correct to an extent, it's correct in that we do provide Content-Type, but it's not right that we only provide it, we actually provide by default Content-Type _and_ Cache-Control, one dynamic, the other static: https://github.com/jekyll/jekyll/blob/master/lib/jekyll/commands/serve/servlet.rb#L40

Do you mind updating the pull request to reflect that?
Thanks!

@galopin

This comment has been minimized.

Show comment
Hide comment
@galopin

galopin Jun 3, 2016

Contributor

@envygeeks thank you for the clarification 💡 I updated this pull request as requested.

Contributor

galopin commented Jun 3, 2016

@envygeeks thank you for the clarification 💡 I updated this pull request as requested.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 3, 2016

Contributor

❤️

@jekyllbot: merge +site

Contributor

envygeeks commented Jun 3, 2016

❤️

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit bf524d6 into jekyll:master Jun 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 3, 2016

@galopin galopin deleted the galopin:patch-1 branch Jun 3, 2016

parkr added a commit that referenced this pull request Jun 4, 2016

Merge branch 'master' into percent_r
* master: (22 commits)
  Update history to reflect merge of #4980 [ci skip]
  werdz
  Use jekyll-mentions and restructure
  Add post about GSoC project.
  Update history to reflect merge of #4976 [ci skip]
  Amend WEBrick default headers documentation
  Update history to reflect merge of #4966 [ci skip]
  .rubocop.yml - remove lib/jekyll.rb
  lib/jekyll.rb - fix offenses reported by rubocop method set_timezone is ignored using rubocop:disable Style/AccessorMethodName
  Update history to reflect merge of #4977 [ci skip]
  Update history to reflect merge of #4962 [ci skip]
  Update history to reflect merge of #4959 [ci skip]
  Fixed typo
  Changed github-gem to github-pages
  Included installation instructions
  Installation instructions for github-pages gem
  Added link to windows doc page
  Fix inaccurate HTTP response header field name
  Minor tweak to fix missing apostrophne
  Feedback for flubbed regex and prefer File's directory check
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment