Move bin/jekyll to exe/jekyll to prevent collision with binstubs #5014

Merged
merged 3 commits into from Jun 15, 2016

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Jun 15, 2016

If you run bundle install --binstubs in this repo, lots of executables are created for the dependencies of this project. The directory is not ignored because we have historically kept our executable (i.e. the jekyll CLI command) in this directory.

This PR moves it to exe/jekyll and ignores the bin/ directory.

@SuriyaaKudoIsc

This comment has been minimized.

Show comment
Hide comment
Member

SuriyaaKudoIsc commented Jun 15, 2016

👍

@SuriyaaKudoIsc

This comment has been minimized.

Show comment
Hide comment
Member

SuriyaaKudoIsc commented on 5e343f6 Jun 15, 2016

👍

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 15, 2016

Contributor

:shipit:

Contributor

envygeeks commented Jun 15, 2016

:shipit:

@@ -13,6 +13,7 @@
/vendor
Gemfile.lock
_site/
+bin/

This comment has been minimized.

@envygeeks

envygeeks Jun 15, 2016

Contributor

You should probably add !bin/jekyll because we need that to be tracked.

@envygeeks

envygeeks Jun 15, 2016

Contributor

You should probably add !bin/jekyll because we need that to be tracked.

This comment has been minimized.

@parkr

parkr Jun 15, 2016

Member

The PR body explains why that is not necessary.

@parkr

parkr Jun 15, 2016

Member

The PR body explains why that is not necessary.

This comment has been minimized.

@envygeeks

envygeeks Jun 15, 2016

Contributor

@parkr yeah I noticed that after I commented 😊

@envygeeks

envygeeks Jun 15, 2016

Contributor

@parkr yeah I noticed that after I commented 😊

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jun 15, 2016

Contributor

Looks like some of our stuff is tightly coupled to bin?

Contributor

envygeeks commented Jun 15, 2016

Looks like some of our stuff is tightly coupled to bin?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 15, 2016

Member

Looks like some of our stuff is tightly coupled to bin?

Yep, in features. Fixing.

Member

parkr commented Jun 15, 2016

Looks like some of our stuff is tightly coupled to bin?

Yep, in features. Fixing.

@parkr parkr added the internal label Jun 15, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 15, 2016

Member

@jekyllbot: merge +minor

Member

parkr commented Jun 15, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 6239bca into master Jun 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the exe branch Jun 15, 2016

jekyllbot added a commit that referenced this pull request Jun 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment