rubocop: lib/jekyll/convertible.rb style fixes #5031

Merged
merged 1 commit into from Jun 25, 2016

Conversation

Projects
None yet
3 participants
@ayastreb
Contributor

ayastreb commented Jun 25, 2016

#4885

As discussed with @parkr I moved out code style fixes from bigger PR (#4961).

In this PR I fixed all the style issues in convertible.rb
I did not remove convertible.rb from .rubocop.yml because there are still a couple of "ABC too high"/"method too long" errors.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 25, 2016

Member

Perfect, thank you!!

@jekyllbot: merge +dev

Member

parkr commented Jun 25, 2016

Perfect, thank you!!

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit cdee574 into jekyll:master Jun 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 25, 2016

parkr added a commit that referenced this pull request Jun 29, 2016

Merge branch 'master' into remove-jruby-and-ruby-head
* master: (41 commits)
  Fix rubocop offenses on master.
  script/fmt: print Rubocop version
  Update history to reflect merge of #5030 [ci skip]
  rubocop: separate deprecator error messages
  Update history to reflect merge of #5031 [ci skip]
  Update history to reflect merge of #5032 [ci skip]
  rubocop: fix code style
  rubocop: fix code style
  rubocop: fix code style
  Update history to reflect merge of #5024 [ci skip]
  Update history to reflect merge of #5025 [ci skip]
  utils: check that the object is a hash when merging default_proc
  Update history to reflect merge of #5026 [ci skip]
  rubocop: refactor modified? method
  Add a benchmark for capture vs. assign in Liquid. [ci skip]
  Update history to reflect merge of #5027 [ci skip]
  Add generator-jekyllized to third party plugins
  rubocop: fix code style
  rubocop: fix code style
  rubocop: fix code style
  ...

@parkr parkr referenced this pull request Aug 30, 2016

Closed

Make jekyll/jekyll code compliant with rubocop rules #4885

114 of 115 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment