rubocop: lib/jekyll/document.rb complexity fixes #5045

Merged
merged 2 commits into from Aug 30, 2016

Conversation

Projects
None yet
3 participants
@ayastreb
Contributor

ayastreb commented Jul 1, 2016

#4885

This PR is extracted from #4961
Here I reduced merge_data! and read methods' ABC size and now there are no rubocop errors in document.rb
I also moved helper methods like categories_from_path, populate_categories etc to private.

There are still a couple of methods duplicated with convertible.rb (e.g. yaml_file?, asset_file?, sass_file?, coffeescript_file?, published?, write). I plan to extract those duplicated code to some common place after finishing with rubocop fixes in convertible.rb

@parkr parkr self-assigned this Aug 24, 2016

@pathawks pathawks referenced this pull request Aug 25, 2016

Closed

Make jekyll/jekyll code compliant with rubocop rules #4885

114 of 115 tasks complete
@ayastreb

This comment has been minimized.

Show comment
Hide comment
@ayastreb

ayastreb Aug 25, 2016

Contributor

I've rebased this PR to latest master and fixed some new rubocop errors.

Contributor

ayastreb commented Aug 25, 2016

I've rebased this PR to latest master and fixed some new rubocop errors.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 30, 2016

Member

OK, this LGTM.

Member

parkr commented Aug 30, 2016

OK, this LGTM.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 30, 2016

Member

@jekyllbot: merge +dev

Member

parkr commented Aug 30, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 6b121d2 into jekyll:master Aug 30, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Approved by @parkr. Requires 1 more LGTM.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment