Put the path into the url so the dir method will return the expected inf... #506

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

...ormation.

Currently the dir method for a page will always return nil because it expects the path to be in the url. However, the path is not included in the url except the version we pass to the view layer.

This change inserts the path into the object's url so that the dir method can function as expected.

fotos referenced this pull request Apr 9, 2012

Merged

Added path in url. #536

Contributor

fotos commented Apr 9, 2012

Damn... I just redid this fix.

I decided to use your fix which was a bit cleaner but added some tests.
Perhaps you should close this pull request to avoid confusion?

Okay. Good luck getting it accepted. I'd like to see this one fixed.

Closing since #536 duplicates this request, but adds tests.

Painted-Fox closed this Apr 9, 2012

Contributor

fotos commented Mar 11, 2013

@MrWerewolf certainly took some time but I managed to get it merged! ;)

jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.