New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use activesupport < 5 if we are on a Ruby < 2.2.2 #5100

Merged
merged 1 commit into from Jul 13, 2016

Conversation

Projects
None yet
5 participants
@Crunch09
Member

Crunch09 commented Jul 12, 2016

ActiveSupport 5.0.x depends on Ruby >= 2.2.2.

I only added it to the test_legacy and site group because activesupport is an indirect dependency of shoulda (via shoulda-matchers) and an indirect dependency of jekyll-mentions and jemoji (both via html-pipeline.)

@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Jul 12, 2016

Member

One test failed for 2.2.4 and jRuby but it seems unrelated?

Member

Crunch09 commented Jul 12, 2016

One test failed for 2.2.4 and jRuby but it seems unrelated?

Show outdated Hide outdated Gemfile
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 12, 2016

Member

A couple things in my comment above. 😄 Thanks!

Member

parkr commented Jul 12, 2016

A couple things in my comment above. 😄 Thanks!

@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Jul 12, 2016

Member

Done :)

Member

Crunch09 commented Jul 12, 2016

Done :)

@@ -2,6 +2,9 @@ source "https://rubygems.org"
gemspec :name => "jekyll"
gem "rake", "~> 11.0"
gem "activesupport", "~> 4.2", :groups => [:test_legacy, :site] if RUBY_ENGINE == 'ruby' && RUBY_VERSION < '2.2.2'

This comment has been minimized.

@parkr

parkr Jul 12, 2016

Member

Is RUBY_ENGINE necessary here?

@parkr

parkr Jul 12, 2016

Member

Is RUBY_ENGINE necessary here?

This comment has been minimized.

@Crunch09

Crunch09 Jul 13, 2016

Member

@parkr Good question, i used Rails' ruby_version_check.rb as an example but could be possible to leave it out i guess.

@Crunch09

Crunch09 Jul 13, 2016

Member

@parkr Good question, i used Rails' ruby_version_check.rb as an example but could be possible to leave it out i guess.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 12, 2016

Member

Thank you! One more question, thanks for sticking with me!

Member

parkr commented Jul 12, 2016

Thank you! One more question, thanks for sticking with me!

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 13, 2016

Contributor

I thought we dropped activesupport, why did it make a come back?

Contributor

envygeeks commented Jul 13, 2016

I thought we dropped activesupport, why did it make a come back?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 13, 2016

Contributor

To also add, this isn't really necessary, or shouldn't be. AFAIW both Gem and Bundler now do this automatically. In that if we want Rails and we do ~>4 and it finds 5.0 and it's not supported on 2.1 then it will install the latest version of "4" that is. Otherwise it will install the latest version of 5.x. I've only heard rumors of this and never actually tested.

Contributor

envygeeks commented Jul 13, 2016

To also add, this isn't really necessary, or shouldn't be. AFAIW both Gem and Bundler now do this automatically. In that if we want Rails and we do ~>4 and it finds 5.0 and it's not supported on 2.1 then it will install the latest version of "4" that is. Otherwise it will install the latest version of 5.x. I've only heard rumors of this and never actually tested.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jul 13, 2016

Member

Travis was choking earlier.

Member

pathawks commented Jul 13, 2016

Travis was choking earlier.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 13, 2016

Member

@envygeeks We're using jekyll-mentions to automatically mentionify @mentions in jekyllrb.com. activesupport is a dependency of html-pipeline, which is used by jekyll-mentions.

LGTM.

@jekyllbot: merge +dev

Member

parkr commented Jul 13, 2016

@envygeeks We're using jekyll-mentions to automatically mentionify @mentions in jekyllrb.com. activesupport is a dependency of html-pipeline, which is used by jekyll-mentions.

LGTM.

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 070267a into jekyll:master Jul 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 13, 2016

parkr added a commit that referenced this pull request Jul 13, 2016

@Crunch09 Crunch09 deleted the Crunch09:fix_activesupport_dependency branch Jul 13, 2016

@parkr parkr referenced this pull request Jul 15, 2016

Merged

Bump Active Support dependency to version >= 2 #257

3 of 3 tasks complete

stevecheckoway added a commit to stevecheckoway/jekyll that referenced this pull request Jul 24, 2016

stevecheckoway added a commit to stevecheckoway/jekyll that referenced this pull request Jul 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment