hooks: move after_init hook call at the end of Site.initialize #5106

Merged
merged 1 commit into from Jul 16, 2016

Conversation

Projects
None yet
4 participants
@ayastreb
Contributor

ayastreb commented Jul 15, 2016

Fix #4861

as discussed in the comments, moved after_init hook at the end of Site initialization

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 16, 2016

Member

LGTM. @envygeeks, think this looks right? Seems like since it's after setup, we can write hooks for this in _plugins like you'd expect. 😄

Member

parkr commented Jul 16, 2016

LGTM. @envygeeks, think this looks right? Seems like since it's after setup, we can write hooks for this in _plugins like you'd expect. 😄

@parkr parkr added the fix label Jul 16, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 16, 2016

Contributor

LGTM! ❤️

Contributor

envygeeks commented Jul 16, 2016

LGTM! ❤️

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 16, 2016

Member

@jekyllbot: merge +bug

Member

parkr commented Jul 16, 2016

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit ed98597 into jekyll:master Jul 16, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jekyll/lgtm Approved by @parkr and @envygeeks.

@jekyllbot jekyllbot added bug fix labels Jul 16, 2016

jekyllbot added a commit that referenced this pull request Jul 16, 2016

stevecheckoway added a commit to stevecheckoway/jekyll that referenced this pull request Jul 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment