New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly, improve PNG compression. #5112

Merged
merged 1 commit into from Jul 19, 2016

Conversation

Projects
None yet
4 participants
@XhmikosR
Contributor

XhmikosR commented Jul 18, 2016

Before: 101 KB (103.742 bytes)
After: 100 KB (102.817 bytes)

Slightly, improve PNG compression.
Before: 101 KB (103.742 bytes)
After:  100 KB (102.817 bytes)
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 18, 2016

Contributor

Seeing as there are several vulnerabilities surrounding PNG, provide your compression method so we can verify it before accepting this. I'm hesitant to accept fonts and images without verification.

Contributor

envygeeks commented Jul 18, 2016

Seeing as there are several vulnerabilities surrounding PNG, provide your compression method so we can verify it before accepting this. I'm hesitant to accept fonts and images without verification.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jul 18, 2016

Contributor

No, I'm trying to inject malware specific to jekyllrb.com.

Come on, not this crap again.

Contributor

XhmikosR commented Jul 18, 2016

No, I'm trying to inject malware specific to jekyllrb.com.

Come on, not this crap again.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 18, 2016

Contributor

It is what it is, whether your like it or not. I'm not good at my job because I'm lax.

Contributor

envygeeks commented Jul 18, 2016

It is what it is, whether your like it or not. I'm not good at my job because I'm lax.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jul 18, 2016

Contributor

I don't want to flame this anymore, but try to distinguish the people.

zopflipng.exe -m --lossy_transparent -y --iterations=1000
Contributor

XhmikosR commented Jul 18, 2016

I don't want to flame this anymore, but try to distinguish the people.

zopflipng.exe -m --lossy_transparent -y --iterations=1000
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 19, 2016

Member

@envygeeks If we could add that to CI, that would be great. Do we already have security vulnerability scanning? If not, then we may not be able to reliably catch things like a potential malware from our known contributors. I certainly wouldn't suspect @XhmikosR or any of our other previous contributors of placing malware in an asset like this. Maybe the system could ensure we'd catch it and do so without having to ask tough and sometimes interrogative questions like this ourselves.

@XhmikosR Haha less than 1,000 bytes! But I'll take it. Thanks!

@jekyllbot: merge +site

Member

parkr commented Jul 19, 2016

@envygeeks If we could add that to CI, that would be great. Do we already have security vulnerability scanning? If not, then we may not be able to reliably catch things like a potential malware from our known contributors. I certainly wouldn't suspect @XhmikosR or any of our other previous contributors of placing malware in an asset like this. Maybe the system could ensure we'd catch it and do so without having to ask tough and sometimes interrogative questions like this ourselves.

@XhmikosR Haha less than 1,000 bytes! But I'll take it. Thanks!

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 2b4680b into jekyll:master Jul 19, 2016

1 of 2 checks passed

jekyll/lgtm Awaiting approval from at least 2 maintainers.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 19, 2016

@XhmikosR XhmikosR deleted the XhmikosR:img-compression branch Jul 19, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 19, 2016

Contributor

@parkr I can have Hulk scan it behind the scenes like we do our own assets if you want.

Contributor

envygeeks commented Jul 19, 2016

@parkr I can have Hulk scan it behind the scenes like we do our own assets if you want.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 19, 2016

Member

@envygeeks That would work.

Member

parkr commented Jul 19, 2016

@envygeeks That would work.

stevecheckoway added a commit to stevecheckoway/jekyll that referenced this pull request Jul 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment