tests: Typo fixes. #5114

Merged
merged 1 commit into from Jul 19, 2016

Conversation

Projects
None yet
6 participants
@XhmikosR
Contributor

XhmikosR commented Jul 18, 2016

No description provided.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 18, 2016

Contributor

The word is jewelers not jewellers. You created a typo trying to fix a typo.

Contributor

envygeeks commented Jul 18, 2016

The word is jewelers not jewellers. You created a typo trying to fix a typo.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jul 18, 2016

Contributor

Might be a North America specific idiom I guess. I can revert it if I find some official source.

Contributor

XhmikosR commented Jul 18, 2016

Might be a North America specific idiom I guess. I can revert it if I find some official source.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 18, 2016

Contributor

No. It's just US American English. In England I've seen it spelled both ways (though rarely.) In Canada I've only ever seen it spelled the double L way. In US American English we spell it "Jeweler" and "Jewelers."

Contributor

envygeeks commented Jul 18, 2016

No. It's just US American English. In England I've seen it spelled both ways (though rarely.) In Canada I've only ever seen it spelled the double L way. In US American English we spell it "Jeweler" and "Jewelers."

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jul 18, 2016

Contributor

All right, reverted it.

Personally, I've only seen it with double L, although I'm not a native English speaker, anyway.

Contributor

XhmikosR commented Jul 18, 2016

All right, reverted it.

Personally, I've only seen it with double L, although I'm not a native English speaker, anyway.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jul 18, 2016

Contributor

BTW, regarding front-matter. Can you guys make a choice and stick with it? I mean, I see in docs it's front Matter, front matter etc.

Contributor

XhmikosR commented Jul 18, 2016

BTW, regarding front-matter. Can you guys make a choice and stick with it? I mean, I see in docs it's front Matter, front matter etc.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 18, 2016

Contributor

Personally I prefer frontmatter but front-matter is what I would assume is the proper way if you press me. What does @jekyll/core and @jekyll/ecosystem think? I think front-matter (the choice you made) is a good one if I'm pressed to be proper.

Contributor

envygeeks commented Jul 18, 2016

Personally I prefer frontmatter but front-matter is what I would assume is the proper way if you press me. What does @jekyll/core and @jekyll/ecosystem think? I think front-matter (the choice you made) is a good one if I'm pressed to be proper.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 18, 2016

Contributor

LGTM.

Contributor

envygeeks commented Jul 18, 2016

LGTM.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jul 18, 2016

Contributor

Let me know and I will update the PR to use whatever you choose consistently across the codebase.

Contributor

XhmikosR commented Jul 18, 2016

Let me know and I will update the PR to use whatever you choose consistently across the codebase.

@mertkahyaoglu

This comment has been minimized.

Show comment
Hide comment
@mertkahyaoglu

mertkahyaoglu Jul 18, 2016

Member

My vote for front matter 😁

Member

mertkahyaoglu commented Jul 18, 2016

My vote for front matter 😁

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jul 18, 2016

Member

In jekyll/jekyll#2396 it was decided that we would use "front matter"

Member

pathawks commented Jul 18, 2016

In jekyll/jekyll#2396 it was decided that we would use "front matter"

test/test_regenerator.rb
@@ -107,7 +107,7 @@ class TestRegenerator < JekyllUnitTest
File.rename(@layout_path + ".tmp", @layout_path)
end
- should "handle deleted/nonexistent dependencies" do
+ should "handle deleted/non-existent dependencies" do

This comment has been minimized.

@pathawks

pathawks Jul 18, 2016

Member

nonexistent Is correct.

This comment has been minimized.

@XhmikosR

XhmikosR Jul 18, 2016

Contributor

I disagree. It's a combination of 2 words but anyway I'll revert it since I
have no interest in debating this.

On Jul 18, 2016 21:08, "Pat Hawks" notifications@github.com wrote:

In test/test_regenerator.rb
#5114 (comment):

@@ -107,7 +107,7 @@ class TestRegenerator < JekyllUnitTest
File.rename(@layout_path + ".tmp", @layout_path)
end

  • should "handle deleted/nonexistent dependencies" do
  • should "handle deleted/non-existent dependencies" do

nonexistent http://www.dictionary.com/browse/nonexistent Is correct.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jekyll/jekyll/pull/5114/files/4192bf71350b77f080d9f5b66028bcb8124470e0#r71198002,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVVtToR7YCQUXbbP5C2k2fP1SM4p1mTks5qW8EGgaJpZM4JO6oT
.

@XhmikosR

XhmikosR Jul 18, 2016

Contributor

I disagree. It's a combination of 2 words but anyway I'll revert it since I
have no interest in debating this.

On Jul 18, 2016 21:08, "Pat Hawks" notifications@github.com wrote:

In test/test_regenerator.rb
#5114 (comment):

@@ -107,7 +107,7 @@ class TestRegenerator < JekyllUnitTest
File.rename(@layout_path + ".tmp", @layout_path)
end

  • should "handle deleted/nonexistent dependencies" do
  • should "handle deleted/non-existent dependencies" do

nonexistent http://www.dictionary.com/browse/nonexistent Is correct.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jekyll/jekyll/pull/5114/files/4192bf71350b77f080d9f5b66028bcb8124470e0#r71198002,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVVtToR7YCQUXbbP5C2k2fP1SM4p1mTks5qW8EGgaJpZM4JO6oT
.

test/test_static_file.rb
@@ -86,7 +86,7 @@ def setup_static_file_with_defaults(base, dir, name, defaults)
assert_equal "/dir/subdir", static_file.destination_rel_dir
end
- should "be writable by default" do
+ should "be writeable by default" do

This comment has been minimized.

@pathawks

pathawks Jul 18, 2016

Member

Why this alternate spelling?

@pathawks

pathawks Jul 18, 2016

Member

Why this alternate spelling?

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jul 18, 2016

Contributor

Should be OK now.

Contributor

XhmikosR commented Jul 18, 2016

Should be OK now.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 19, 2016

Member

Yeah we decided to go with front matter. 👍

Member

parkr commented Jul 19, 2016

Yeah we decided to go with front matter. 👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 19, 2016

Member

LGTM.

Member

parkr commented Jul 19, 2016

LGTM.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 19, 2016

Member

I see a LGTM from Jordon above. I'll merge.

@jekyllbot: merge +dev

Member

parkr commented Jul 19, 2016

I see a LGTM from Jordon above. I'll merge.

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 0963f85 into jekyll:master Jul 19, 2016

1 of 2 checks passed

jekyll/lgtm Approved by @parkr. Requires 1 more LGTM.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 19, 2016

@XhmikosR XhmikosR deleted the XhmikosR:typo-fixes branch Jul 19, 2016

stevecheckoway added a commit to stevecheckoway/jekyll that referenced this pull request Jul 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment