docs: fix link to plugins page source #5122

Merged
merged 1 commit into from Jul 21, 2016

Conversation

Projects
None yet
3 participants
@ayastreb
Contributor

ayastreb commented Jul 21, 2016

The link to plugins source page is broken in the docs and leads to 404 error page.
I've changed it from relative URL to absolute URL.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 21, 2016

Member

@ayastreb When you run bundle exec rake site:generate locally, this is clobbered because this file comes from .github/CONTRIBUTING.md. We should change it there instead!

Member

parkr commented Jul 21, 2016

@ayastreb When you run bundle exec rake site:generate locally, this is clobbered because this file comes from .github/CONTRIBUTING.md. We should change it there instead!

@parkr parkr added the documentation label Jul 21, 2016

@ayastreb

This comment has been minimized.

Show comment
Hide comment
@ayastreb

ayastreb Jul 21, 2016

Contributor

@parkr I reverted site/_docs/contributing.md and moved this fix to .github/CONTRIBUTING.md, now bundle exec rake site:generate runs ok, but it changes the site/_docs/contributing.md localy 😄
Should I change it in both files and commit?

Contributor

ayastreb commented Jul 21, 2016

@parkr I reverted site/_docs/contributing.md and moved this fix to .github/CONTRIBUTING.md, now bundle exec rake site:generate runs ok, but it changes the site/_docs/contributing.md localy 😄
Should I change it in both files and commit?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 21, 2016

Member

Should I change it in both files and commit?

Yes please! And squash into one commit please 😄

Member

parkr commented Jul 21, 2016

Should I change it in both files and commit?

Yes please! And squash into one commit please 😄

@ayastreb

This comment has been minimized.

Show comment
Hide comment
@ayastreb

ayastreb Jul 21, 2016

Contributor

Done!

Contributor

ayastreb commented Jul 21, 2016

Done!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 21, 2016

Member

LGTM. 😄

@jekyllbot: merge +site

Member

parkr commented Jul 21, 2016

LGTM. 😄

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit c1e1d2a into jekyll:master Jul 21, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Awaiting approval from at least 2 maintainers.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 21, 2016

@ayastreb ayastreb deleted the ayastreb:docs-fix branch Jul 21, 2016

@ayastreb

This comment has been minimized.

Show comment
Hide comment
@ayastreb

ayastreb Jul 22, 2016

Contributor

@parkr, hm... the link is still broken here - https://jekyllrb.com/docs/contributing/
do you need to deploy docs fixes manually or will it get there automatically somehow? 😄

Contributor

ayastreb commented Jul 22, 2016

@parkr, hm... the link is still broken here - https://jekyllrb.com/docs/contributing/
do you need to deploy docs fixes manually or will it get there automatically somehow? 😄

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 22, 2016

Member

@ayastreb It's manual - haven't done it yet!

Member

parkr commented Jul 22, 2016

@ayastreb It's manual - haven't done it yet!

stevecheckoway added a commit to stevecheckoway/jekyll that referenced this pull request Jul 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment