Add `--baseurl` to `build` subcommand #5135

Merged
merged 1 commit into from Jul 25, 2016

Conversation

Projects
None yet
3 participants
@chrisfinazzo
Contributor

chrisfinazzo commented Jul 25, 2016

I had this rebased and ready to go yesterday, but ran into this issue - which explains the Travis failures I had been seeing. I've since updated and I think this is ready to go.

@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Jul 25, 2016

Contributor

I know I've seen this before. Can we just mkdir here and elsewhere as appropriate?

Contributor

chrisfinazzo commented Jul 25, 2016

I know I've seen this before. Can we just mkdir here and elsewhere as appropriate?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 25, 2016

Member

LGTM.

@chrisfinazzo I think that has to do with the value of Dir.pwd when the test runs. Or something is being set that shouldn't be. It's been flaky lately.

Member

parkr commented Jul 25, 2016

LGTM.

@chrisfinazzo I think that has to do with the value of Dir.pwd when the test runs. Or something is being set that shouldn't be. It's been flaky lately.

@parkr parkr added the enhancement label Jul 25, 2016

@parkr parkr changed the title from Add baseurl subcommand, fixes #4919 to Add `--baseurl` to `build` subcommand Jul 25, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 25, 2016

Member

Fixes #4919.

@jekyllbot: merge +minor

Member

parkr commented Jul 25, 2016

Fixes #4919.

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 6b0b641 into jekyll:master Jul 25, 2016

0 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
jekyll/lgtm Approved by @parkr. Requires 1 more LGTM.

jekyllbot added a commit that referenced this pull request Jul 25, 2016

@chrisfinazzo chrisfinazzo deleted the chrisfinazzo:baseurl-subcommand branch Jul 25, 2016

@parkr parkr referenced this pull request in github/opensource.guide Aug 9, 2016

Merged

Add html-proofer to test suite #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment