New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about script/fmt #5138

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
4 participants
@chrisfinazzo
Contributor

chrisfinazzo commented Jul 25, 2016

No description provided.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 26, 2016

Member

LGTM. Thanks!

Member

parkr commented Jul 26, 2016

LGTM. Thanks!

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 26, 2016

Contributor

Rubocop should be under the Github Styleguide because we most importantly use the Github Styleguide to setup Rubocop in a similar format. We do not use many of the rules they define by default.

Contributor

envygeeks commented Jul 26, 2016

Rubocop should be under the Github Styleguide because we most importantly use the Github Styleguide to setup Rubocop in a similar format. We do not use many of the rules they define by default.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 26, 2016

Member

@envygeeks Are you saying you don't like the wording of Chris's addition?

Member

parkr commented Jul 26, 2016

@envygeeks Are you saying you don't like the wording of Chris's addition?

@parkr parkr added the documentation label Jul 26, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 26, 2016

Member

@jekyllbot: merge +site

Member

parkr commented Jul 26, 2016

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit c83246b into jekyll:master Jul 26, 2016

0 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
jekyll/lgtm Approved by @parkr. Requires 1 more LGTM.

jekyllbot added a commit that referenced this pull request Jul 26, 2016

parkr added a commit that referenced this pull request Jul 26, 2016

@chrisfinazzo chrisfinazzo deleted the chrisfinazzo:note-about-fmt branch Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment