Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial 404 page #5143

Merged
merged 7 commits into from Jul 28, 2016
Merged

Initial 404 page #5143

merged 7 commits into from Jul 28, 2016

Conversation

adampetrie
Copy link

This is a first go at addressing #5039. Not sure exactly what we're looking for here so I figured I'd open a PR and use the feedback to help this take shape.

<section class="intro">
<div class="grid">
<div class="unit whole center-on-mobiles">
<p class="first">404 - Page Not Found</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be generic "not found" not everything is a page.

@adampetrie
Copy link
Author

Here it is now:

screen shot 2016-07-27 at 7 09 58 pm

A bit more error-pagey IMO.

@benbalter
Copy link
Contributor

This is terrible, but instead of "404 - not found", what about, "Huh. It seems that page is Hyde-ing..."?

@parkr
Copy link
Member

parkr commented Jul 27, 2016

@adampetrie Much better than before! I wonder if we should provide a short description of each page, e.g. Community – Connect with other Jekyllites etc? Giving a little insight into what's on the page would fill out the blank space here and provide a bit more help getting to the resource they are looking for.

<a href="/">Home</a>
</li>
<li>
<a href="/docs/home/">Docs</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call this Documentation – it's Docs in the header because it's too wide 😄

@adampetrie
Copy link
Author

adampetrie commented Jul 27, 2016

@benbalter - I am pro puns so the 'hyde-ing' bit is awesome. There should probably be a 404 mention somewhere on the page though?

@parkr - Community seems like the only one that might need further explanation and is arguably not 404 page worthy - I could just remove it altogether?

@adampetrie
Copy link
Author

How's this? I'm just spit-ballin' here...

screen shot 2016-07-27 at 7 51 27 pm

@parkr
Copy link
Member

parkr commented Jul 28, 2016

LGTM. Let's ship it!

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit f29ebc4 into jekyll:master Jul 28, 2016
jekyllbot added a commit that referenced this pull request Jul 28, 2016
parkr added a commit that referenced this pull request Aug 2, 2016
* master:
  Update history to reflect merge of #5152 [ci skip]
  Missing trailing |
  Update history to reflect merge of #5158 [ci skip]
  Also include LICENSE and README
  note that themes have been released
  Update history to reflect merge of #5143 [ci skip]
  Update history to reflect merge of #5150 [ci skip]
  Revert "Readability: lib/jekyll/static_file.rb."
  include theme directories in default gemspec
  [site] enable excerpts
  Centre align text and use nav styles on helpful links.
  Puns FTW
  Add helpful links and minor alignment tweak.
  Create error template that has no main nav or footer.
  Use more generic wording.
  sitemap: false so that the error page is not indexed
  Initial 404 page
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants