New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial 404 page #5143

Merged
merged 7 commits into from Jul 28, 2016

Conversation

Projects
None yet
5 participants
@adampetrie
Contributor

adampetrie commented Jul 27, 2016

This is a first go at addressing #5039. Not sure exactly what we're looking for here so I figured I'd open a PR and use the feedback to help this take shape.

Adam Petrie
Show outdated Hide outdated site/404.html
Show outdated Hide outdated site/404.html
@adampetrie

This comment has been minimized.

Show comment
Hide comment
@adampetrie

adampetrie Jul 27, 2016

Contributor

Here it is now:

screen shot 2016-07-27 at 7 09 58 pm

A bit more error-pagey IMO.

Contributor

adampetrie commented Jul 27, 2016

Here it is now:

screen shot 2016-07-27 at 7 09 58 pm

A bit more error-pagey IMO.

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Jul 27, 2016

Contributor

This is terrible, but instead of "404 - not found", what about, "Huh. It seems that page is Hyde-ing..."?

Contributor

benbalter commented Jul 27, 2016

This is terrible, but instead of "404 - not found", what about, "Huh. It seems that page is Hyde-ing..."?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 27, 2016

Member

@adampetrie Much better than before! I wonder if we should provide a short description of each page, e.g. Community – Connect with other Jekyllites etc? Giving a little insight into what's on the page would fill out the blank space here and provide a bit more help getting to the resource they are looking for.

Member

parkr commented Jul 27, 2016

@adampetrie Much better than before! I wonder if we should provide a short description of each page, e.g. Community – Connect with other Jekyllites etc? Giving a little insight into what's on the page would fill out the blank space here and provide a bit more help getting to the resource they are looking for.

Show outdated Hide outdated site/404.html
@adampetrie

This comment has been minimized.

Show comment
Hide comment
@adampetrie

adampetrie Jul 27, 2016

Contributor

@benbalter - I am pro puns so the 'hyde-ing' bit is awesome. There should probably be a 404 mention somewhere on the page though?

@parkr - Community seems like the only one that might need further explanation and is arguably not 404 page worthy - I could just remove it altogether?

Contributor

adampetrie commented Jul 27, 2016

@benbalter - I am pro puns so the 'hyde-ing' bit is awesome. There should probably be a 404 mention somewhere on the page though?

@parkr - Community seems like the only one that might need further explanation and is arguably not 404 page worthy - I could just remove it altogether?

Adam Petrie added some commits Jul 27, 2016

@adampetrie

This comment has been minimized.

Show comment
Hide comment
@adampetrie

adampetrie Jul 27, 2016

Contributor

How's this? I'm just spit-ballin' here...

screen shot 2016-07-27 at 7 51 27 pm

Contributor

adampetrie commented Jul 27, 2016

How's this? I'm just spit-ballin' here...

screen shot 2016-07-27 at 7 51 27 pm

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 28, 2016

Member

LGTM. Let's ship it!

@jekyllbot: merge +site

Member

parkr commented Jul 28, 2016

LGTM. Let's ship it!

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit f29ebc4 into jekyll:master Jul 28, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Awaiting approval from at least 2 maintainers.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 28, 2016

parkr added a commit that referenced this pull request Aug 2, 2016

Merge branch 'master' into build-the-site
* master:
  Update history to reflect merge of #5152 [ci skip]
  Missing trailing |
  Update history to reflect merge of #5158 [ci skip]
  Also include LICENSE and README
  note that themes have been released
  Update history to reflect merge of #5143 [ci skip]
  Update history to reflect merge of #5150 [ci skip]
  Revert "Readability: lib/jekyll/static_file.rb."
  include theme directories in default gemspec
  [site] enable excerpts
  Centre align text and use nav styles on helpful links.
  Puns FTW
  Add helpful links and minor alignment tweak.
  Create error template that has no main nav or footer.
  Use more generic wording.
  sitemap: false so that the error page is not indexed
  Initial 404 page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment