Add test to build the default site #5154

Merged
merged 8 commits into from Aug 2, 2016

Conversation

Projects
None yet
4 participants
@benbalter
Contributor

benbalter commented Jul 28, 2016

Motivated by #5153, and inspired by our tests on the Pages Gem, this PR adds a purposely (for now) failing test to generate and build Jekyll's default site.

The test is quick to run (2.3s, including Ruby's boot on my machine), and would provide a good smoke test / sanity check that the default Jekyll action works out of the box.

@benbalter benbalter changed the title from add test to build the default site to Add test to build the default site Jul 28, 2016

@benbalter benbalter referenced this pull request in jekyll/minima Jul 28, 2016

Closed

Ship 1.0 #1

4 of 4 tasks complete
.travis.yml
@@ -19,7 +19,7 @@ env:
matrix:
- TEST_SUITE=test
- TEST_SUITE=cucumber
-
+ - TEST_SUITE=default-site

This comment has been minimized.

@parkr

parkr Jul 28, 2016

Member

Does this need to run 3 times, once per Ruby version?

@parkr

parkr Jul 28, 2016

Member

Does this need to run 3 times, once per Ruby version?

This comment has been minimized.

@benbalter

benbalter Aug 1, 2016

Contributor

Your call. I'm fine with it running once? If so, what's the best way to do that?

@benbalter

benbalter Aug 1, 2016

Contributor

Your call. I'm fine with it running once? If so, what's the best way to do that?

This comment has been minimized.

@parkr

parkr Aug 1, 2016

Member

To add it only once, choose your fave Ruby version and add it to the matrix.include section above this one (see fmt):

- rvm: 2.3.0
  env: TEST_SUITE=test-jekyll-new

Or whatever 😄

@parkr

parkr Aug 1, 2016

Member

To add it only once, choose your fave Ruby version and add it to the matrix.include section above this one (see fmt):

- rvm: 2.3.0
  env: TEST_SUITE=test-jekyll-new

Or whatever 😄

@parkr parkr modified the milestone: flexible Jul 28, 2016

benbalter and others added some commits Aug 1, 2016

@benbalter benbalter referenced this pull request Aug 1, 2016

Merged

Fix for symlinked themes #5156

parkr added some commits Aug 2, 2016

Merge branch 'master' into build-the-site
* master:
  Update history to reflect merge of #5152 [ci skip]
  Missing trailing |
  Update history to reflect merge of #5158 [ci skip]
  Also include LICENSE and README
  note that themes have been released
  Update history to reflect merge of #5143 [ci skip]
  Update history to reflect merge of #5150 [ci skip]
  Revert "Readability: lib/jekyll/static_file.rb."
  include theme directories in default gemspec
  [site] enable excerpts
  Centre align text and use nav styles on helpful links.
  Puns FTW
  Add helpful links and minor alignment tweak.
  Create error template that has no main nav or footer.
  Use more generic wording.
  sitemap: false so that the error page is not indexed
  Initial 404 page
Merge branch 'master' into build-the-site
* master:
  Update history to reflect merge of #5156 [ci skip]
  Update history to reflect merge of #5177 [ci skip]
  Update history to reflect merge of #5173 [ci skip]
  Minor updates and corrections
  Future True on GitHub Pages note
  resolve theme root before sanitizing
  dont double sanitize theme folder paths

@parkr parkr added the tests label Aug 2, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 2, 2016

Member

Travis is doing weird things. 🆒

@jekyllbot: merge +dev

Member

parkr commented Aug 2, 2016

Travis is doing weird things. 🆒

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 73b7bd8 into master Aug 2, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Awaiting approval from at least 2 maintainers.

@jekyllbot jekyllbot deleted the build-the-site branch Aug 2, 2016

jekyllbot added a commit that referenced this pull request Aug 2, 2016

@DirtyF DirtyF removed this from the flexible milestone May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment