Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Run hooks in priority order. #5157
Low priority hooks are being run before higher priority hooks. This is easy to
Sorting by the negative of the priority and then by the order the hook was
Hmm. Confusingly, the feature file indicates the low priority hooks should run first. That's counter-intuitive and disagrees with plugin priority meanings.
Either the feature file should be fixed, or the
Either way, comparing as a floating point number gives seriously broken results. From the plugin in the commit message, without the patch, I get
plugin priority makes little sense for hooks and plugins, I don't even know why that is there. Everybody can just delegate themselves as high or low, and most don't even matter. For hooks this is even more so, hooks should have a name so that you can insert before or after a specific hook if you need to, but priorities make little sense because everybody will just be high or low.
Ultimately priorities that are not weighted by the user, have little meaning without named meaning.