New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates and corrections #5177

Merged
merged 1 commit into from Aug 2, 2016

Conversation

Projects
None yet
3 participants
@gep13
Contributor

gep13 commented Aug 1, 2016

  • Corrected highlighting on multi-line sections
  • Replace cinst with choco install for consistency
Minor updates and corrections
- Corrected highlighting on multi-line sections
- Replace `cinst` with `choco install` for consistency
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 1, 2016

Member

@gep13 Thanks! What is cinst? Is it the old way of writing choco install?

/cc @jekyll/windows If you wouldn't mind double-checking this, please! ❤️

Member

parkr commented Aug 1, 2016

@gep13 Thanks! What is cinst? Is it the old way of writing choco install?

/cc @jekyll/windows If you wouldn't mind double-checking this, please! ❤️

@parkr parkr added the documentation label Aug 1, 2016

@gep13

This comment has been minimized.

Show comment
Hide comment
@gep13

gep13 Aug 1, 2016

Contributor

@parkr said...
@gep13 Thanks! What is cinst? Is it the old way of writing choco install?

Exactly that, yes. cinst is being phased out, although it still works, in favour of choco install.

Contributor

gep13 commented Aug 1, 2016

@parkr said...
@gep13 Thanks! What is cinst? Is it the old way of writing choco install?

Exactly that, yes. cinst is being phased out, although it still works, in favour of choco install.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 2, 2016

Member

LGTM.

Member

parkr commented Aug 2, 2016

LGTM.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 2, 2016

Member

@jekyllbot: merge +site

Member

parkr commented Aug 2, 2016

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit ae72c64 into jekyll:master Aug 2, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Approved by @parkr. Requires 1 more LGTM.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Aug 2, 2016

parkr added a commit that referenced this pull request Aug 2, 2016

Merge branch 'master' into build-the-site
* master:
  Update history to reflect merge of #5156 [ci skip]
  Update history to reflect merge of #5177 [ci skip]
  Update history to reflect merge of #5173 [ci skip]
  Minor updates and corrections
  Future True on GitHub Pages note
  resolve theme root before sanitizing
  dont double sanitize theme folder paths

@gep13 gep13 deleted the gep13:patch-1 branch Aug 2, 2016

@gep13

This comment has been minimized.

Show comment
Hide comment
@gep13

gep13 Aug 2, 2016

Contributor

@parkr thanks for getting this merged in! Out of curiosity, what are you guys using to power your bot?

Contributor

gep13 commented Aug 2, 2016

@parkr thanks for getting this merged in! Out of curiosity, what are you guys using to power your bot?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 3, 2016

Member

@gep13 My pleasure! Our bot is a home-grown Go app that takes in webhook payloads and does stuff. Basically just glue around https://github.com/google/go-github

Member

parkr commented Aug 3, 2016

@gep13 My pleasure! Our bot is a home-grown Go app that takes in webhook payloads and does stuff. Basically just glue around https://github.com/google/go-github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment