New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appveyor.yml and fix optional deps for Ruby x64 #5180

Merged
merged 2 commits into from Aug 3, 2016

Conversation

Projects
None yet
3 participants
@XhmikosR
Contributor

XhmikosR commented Aug 2, 2016

  • rename variables
  • add default-site target
  • remove fast_finish in order to match Travis CI behavior

A side note, @parkr, should we do something with a .gemrc to skip docs on bundle install?

@XhmikosR XhmikosR changed the title from Update appveyor.yml to Update appveyor.yml and fix optional deps for Ruby x64 Aug 2, 2016

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Aug 2, 2016

Contributor

Another though, how about running cucumber only for the latest (2.3.0) Ruby? It should be -3 builds.

Contributor

XhmikosR commented Aug 2, 2016

Another though, how about running cucumber only for the latest (2.3.0) Ruby? It should be -3 builds.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 2, 2016

Member

A side note, @parkr, should we do something with a .gemrc to skip docs on bundle install?

That's a terrific idea!

Another though, how about running cucumber only for the latest (2.3.0) Ruby? It should be -3 builds.

Another great idea. Fewer checks is definitely better.

/cc #5179

Member

parkr commented Aug 2, 2016

A side note, @parkr, should we do something with a .gemrc to skip docs on bundle install?

That's a terrific idea!

Another though, how about running cucumber only for the latest (2.3.0) Ruby? It should be -3 builds.

Another great idea. Fewer checks is definitely better.

/cc #5179

XhmikosR added some commits Aug 2, 2016

Update appveyor.yml.
* rename variables
* add `default-site` target
* remove `fast_finish` in order to match Travis CI behavior
* run cucumber tests only on the latest Ruby
@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Aug 2, 2016

Contributor

For now I reduced the cucumber tests.

Do you have a working solution for the no doc on install? I tried one earlier but didn't notice any speed improvement.

Contributor

XhmikosR commented Aug 2, 2016

For now I reduced the cucumber tests.

Do you have a working solution for the no doc on install? I tried one earlier but didn't notice any speed improvement.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 2, 2016

Member

Do you have a working solution for the no doc on install? I tried one earlier but didn't notice any speed improvement.

Hm, I googled it and found "Bundler doesn't install RI or RDoc." source. So maybe we're ok.

Member

parkr commented Aug 2, 2016

Do you have a working solution for the no doc on install? I tried one earlier but didn't notice any speed improvement.

Hm, I googled it and found "Bundler doesn't install RI or RDoc." source. So maybe we're ok.

- ruby_folder_version: "23"
ruby_gems_folder: "2.3.0"
- RUBY_FOLDER_VER: "23"
GEMS_FOLDER_VER: "2.3.0"

This comment has been minimized.

@parkr

parkr Aug 2, 2016

Member

Where is the GEMS_FOLDER_VER used?

@parkr

parkr Aug 2, 2016

Member

Where is the GEMS_FOLDER_VER used?

This comment has been minimized.

@XhmikosR

XhmikosR Aug 2, 2016

Contributor

In caching.

@XhmikosR

XhmikosR Aug 2, 2016

Contributor

In caching.

This comment has been minimized.

@parkr

parkr Aug 2, 2016

Member

Cool, thanks.

@parkr

parkr Aug 2, 2016

Member

Cool, thanks.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 2, 2016

Member

LGTM.

Member

parkr commented Aug 2, 2016

LGTM.

@jekyllbot

This comment has been minimized.

Show comment
Hide comment
@jekyllbot

jekyllbot Aug 3, 2016

Contributor

LGTM.

Contributor

jekyllbot commented Aug 3, 2016

LGTM.

@jekyllbot

This comment has been minimized.

Show comment
Hide comment
@jekyllbot

jekyllbot Aug 3, 2016

Contributor

@jekyllbot: merge +dev

Contributor

jekyllbot commented Aug 3, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit cb99cf6 into jekyll:master Aug 3, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jekyll/lgtm Approved by @parkr and @jekyllbot.

jekyllbot added a commit that referenced this pull request Aug 3, 2016

@XhmikosR XhmikosR deleted the XhmikosR:patch-1 branch Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment