New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to link to all files #5199

Merged
merged 3 commits into from Sep 13, 2016

Conversation

Projects
None yet
6 participants
@jeffkole
Contributor

jeffkole commented Aug 3, 2016

Fixes request made in #4624 and bug found in #5182

Adds ability to link to all files
Fixes request made in #4624 and bug found in #5182
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 4, 2016

Contributor

What bug? I see no bug in that documentation.

Contributor

envygeeks commented Aug 4, 2016

What bug? I see no bug in that documentation.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Aug 4, 2016

Member

Thanks @jeffkole link to pages and files works fine now :)

I tested it a bit and noticed that you have to use add a / before the path to a file or Jekyll won't find the file.

{% link /assets/files/doc.pdf %}

Also, just so you know I didn't manage to link to a data file with {% link _data/file.yml %} but's it's out of the scope of this fix I guess.

@envygeeks it wasn't a bug in the documentation but rather in the implementation of the brand new linktag, hence this PR

Member

DirtyF commented Aug 4, 2016

Thanks @jeffkole link to pages and files works fine now :)

I tested it a bit and noticed that you have to use add a / before the path to a file or Jekyll won't find the file.

{% link /assets/files/doc.pdf %}

Also, just so you know I didn't manage to link to a data file with {% link _data/file.yml %} but's it's out of the scope of this fix I guess.

@envygeeks it wasn't a bug in the documentation but rather in the implementation of the brand new linktag, hence this PR

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 5, 2016

Member

@jeffkole Because you added a file to the test fixture site, you have to update another test: https://travis-ci.org/jekyll/jekyll/jobs/149605617

Member

parkr commented Aug 5, 2016

@jeffkole Because you added a file to the test fixture site, you have to update another test: https://travis-ci.org/jekyll/jekyll/jobs/149605617

@jeffkole

This comment has been minimized.

Show comment
Hide comment
@jeffkole

jeffkole Aug 5, 2016

Contributor

@DirtyF That is annoying, isn't it. Looks like static files get a leading slash added to their relative path property. I'll check in a fix.

Contributor

jeffkole commented Aug 5, 2016

@DirtyF That is annoying, isn't it. Looks like static files get a leading slash added to their relative path property. I'll check in a fix.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 6, 2016

Member

LGTM!

Member

parkr commented Aug 6, 2016

LGTM!

parkr added a commit that referenced this pull request Aug 7, 2016

templates.md: {% link %} tag only accepts collection documents
Remove examples of pages/static file links until it's released.
#5182 #5199
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Sep 13, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 13, 2016

Contributor

I like that it has tests. Thanks for adding tests. LGTM.

Contributor

envygeeks commented Sep 13, 2016

I like that it has tests. Thanks for adding tests. LGTM.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 13, 2016

Contributor

Since I don't remember the tag for a feature +minor? I'll let @parkr or somebody else on @jekyll/core deal with the merge.

Contributor

envygeeks commented Sep 13, 2016

Since I don't remember the tag for a feature +minor? I'll let @parkr or somebody else on @jekyll/core deal with the merge.

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Sep 13, 2016

Member

@jekyllbot: merge +minor

Member

mattr- commented Sep 13, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 4888b84 into jekyll:master Sep 13, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jekyll/lgtm Approved by @parkr and @envygeeks.

jekyllbot added a commit that referenced this pull request Sep 13, 2016

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Sep 13, 2016

Member

@envygeeks you were right. It's +minor. 😃

Member

mattr- commented Sep 13, 2016

@envygeeks you were right. It's +minor. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment