Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Exclude node_modules by default #5210
If no 'exclude' directive is specified, exclude node_modules by default.
@envygeeks That's a great idea!
@spudowiar So many people are using Gulp and Grunt to run Jekyll and confused when it takes like 30s to generate their site. Ultimately, it's a sad result of using NPM that you end up with 15,000 files in a
Why not add vendor, gemfile, and gemfile.lock into _config.yml?
will specifying an 'exclude' require node_modules be listed again? Maybe include this too in the exclude list in _config.yml
Sep 28, 2016
added a commit
this pull request
Sep 28, 2016
@parkr: How to include node_modules now that this change has been released?
I've tried this in my
However, the folder node_modules is still excluded.
I'm not very well-versed in Ruby but I think your commit actually forces node_modules to be excluded, instead of making it the default behavior that can be overridden by the user.
Thanks @mxstbr, this works. It's not very intuitive IMHO. Maybe this could be improved some time to honor the include directive and be in line with the documentation:
That's definitely not what happens with this example.