New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby versions in travis.yml #5221

Merged
merged 1 commit into from Aug 12, 2016

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Aug 10, 2016

Add Ruby v2.3.1 to travis.yml. Leaving everything else as is.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 10, 2016

Contributor

2.3.1 is a successor to 2.3.0 not an addition to it. Can you please adjust your pull to reflect that?

Contributor

envygeeks commented Aug 10, 2016

2.3.1 is a successor to 2.3.0 not an addition to it. Can you please adjust your pull to reflect that?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 10, 2016

Member

wasn't sure whether to add or replace.

also upgrade?

  • 2.2.4 -> 2.2.5
  • 2.1.8 -> 2.1.9

jruby latest is 9.1.2.0 .. cant find that in the travis docs...

Member

ashmaroli commented Aug 10, 2016

wasn't sure whether to add or replace.

also upgrade?

  • 2.2.4 -> 2.2.5
  • 2.1.8 -> 2.1.9

jruby latest is 9.1.2.0 .. cant find that in the travis docs...

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 10, 2016

Contributor

Hold tight, I'm cleaning up the .travis.yml file, at that point you can ship a cleaner pull that does all that.

Contributor

envygeeks commented Aug 10, 2016

Hold tight, I'm cleaning up the .travis.yml file, at that point you can ship a cleaner pull that does all that.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 10, 2016

Contributor

@ashmaroli okay, you are good to update, I cleaned up .travis.yml so that you could just update the RVM field without having to worry about updating many values just to update our Rubies.

Contributor

envygeeks commented Aug 10, 2016

@ashmaroli okay, you are good to update, I cleaned up .travis.yml so that you could just update the RVM field without having to worry about updating many values just to update our Rubies.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 10, 2016

Contributor

To add another note, yes, you can update all of them if you wish! We use the succesor pattern, so if there is a new minor release it just replaces the old minor version rather than holding a dozen versions of Ruby, we do this because there is no need to waste Travis-CI capacity.

Contributor

envygeeks commented Aug 10, 2016

To add another note, yes, you can update all of them if you wish! We use the succesor pattern, so if there is a new minor release it just replaces the old minor version rather than holding a dozen versions of Ruby, we do this because there is no need to waste Travis-CI capacity.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 10, 2016

Member

okay.. will test jruby 9.1.2.0 also

Member

ashmaroli commented Aug 10, 2016

okay.. will test jruby 9.1.2.0 also

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 10, 2016

Member

travis is still at gem version 2.5.1 instead of 2.6.6

Member

ashmaroli commented Aug 10, 2016

travis is still at gem version 2.5.1 instead of 2.6.6

@ashmaroli ashmaroli changed the title from Add Ruby2.3.1 to Travis to Update Ruby versions in travis.yml Aug 10, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 11, 2016

Member

LGTM, pending Travis passing.

Member

parkr commented Aug 11, 2016

LGTM, pending Travis passing.

@parkr parkr added the internal label Aug 11, 2016

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 12, 2016

Member

Travis build passed..

Member

ashmaroli commented Aug 12, 2016

Travis build passed..

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 12, 2016

Contributor

LGTM.

Contributor

envygeeks commented Aug 12, 2016

LGTM.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 12, 2016

Contributor

@jekyllbot: merge +dev

Contributor

envygeeks commented Aug 12, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 7262909 into jekyll:master Aug 12, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jekyll/lgtm Approved by @parkr and @envygeeks.

jekyllbot added a commit that referenced this pull request Aug 12, 2016

@ashmaroli ashmaroli deleted the ashmaroli:mod-travis branch Nov 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment