Fix a link in deployment-methods.md #5244

Merged
merged 1 commit into from Aug 18, 2016

Projects

None yet

6 participants

@mkasberg
Contributor

The link to the scp deploy script was broken - it appears someone changed the link text and did not update the matching link text in the markdown footer. To prevent this problem from happening again, and for consistency with the rest of this markdown file, I changed both links to inline style links.

@mkasberg mkasberg referenced this pull request Aug 14, 2016
Closed

Link Broken in deployment-methods.md #5245

4 of 17 tasks complete
@envygeeks
Member

👎 that script uses scss directly, it's preferred to do it via Jekyll itself since it's embedded.

@envygeeks
Member

To note, I already know it was there, but now that it's been brought to attention, I question if it's still viable.

@mkasberg
Contributor

That makes sense. I actually removed that line from my own version of the script. I was just trying to fix the broken link, since it looks bad on the website right now.

Is there a more preferable implementation of that script somewhere that we could link to?

Alternatively, since it's basically a one-liner, what if we just actually write the script into the markdown? Like this:

scp -r _site/* user@server:/home/user/public_html
@envygeeks
Member

I am 👍 on just inlining it. That is what I thought when I seen it.

On Mon, Aug 15, 2016, 3:25 PM Mike Kasberg notifications@github.com wrote:

That makes sense. I actually removed that line from my own version of the
script. I was just trying to fix the broken link, since it looks bad on the
website right now.

Is there a more preferable implementation of that script somewhere that we
could link to?

Alternatively, since it's basically a one-liner, what if we just actually
write the script into the markdown? Like this:

scp -r _site/* user@server:/home/user/public_html


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#5244 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGFsyOaYlMQzI655LAUGH-17GsD5NKaks5qgMtWgaJpZM4Jj9O8
.

@mkasberg mkasberg Fix a link in deployment-methods.md
The link to the scp deploy script was broken - it appears someone
changed the link text and did not update the matching link text in the
markdown footer.

Because the script is really simple, and the script originally linked
includes some unnecessary scss commands, let's just inline the script.
e080c7f
@mkasberg
Contributor

Just updated the pull request to have it inlined.

@envygeeks
Member

LGTM.

@envygeeks envygeeks added bug fix labels Aug 16, 2016
@DirtyF
Member
DirtyF commented Aug 17, 2016

LGTM.

@mattr-
Member
mattr- commented Aug 18, 2016

LGTM

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit d0ae757 into jekyll:master Aug 18, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Approved by @envygeeks. Requires 1 more LGTM.
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@albertvolkman

Also, the text immediately following is an exact duplicate.

screenshot 2016-09-15 13 20 45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment