New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: improve highlight in `Creating a theme` #5249

Merged
merged 1 commit into from Aug 18, 2016

Conversation

Projects
None yet
5 participants
@crispgm
Member

crispgm commented Aug 16, 2016

The words 'for' and 'in' of is ready for you in /path/to/my-awesome-theme! was interpreted as Shell keywords. However, it is the output of a shell command and should not be highlighted. And jekyll new-theme has no syntax highlighting as Shell command.

So I change the tag into plaintext instead.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 17, 2016

Contributor

LGTM. /cc @jekyll/documentation @jekyll/core

Contributor

envygeeks commented Aug 17, 2016

LGTM. /cc @jekyll/documentation @jekyll/core

@adamhollett

This comment has been minimized.

Show comment
Hide comment
@adamhollett

adamhollett Aug 18, 2016

Contributor

Looks fine to me too. Makes a lot of sense!

Contributor

adamhollett commented Aug 18, 2016

Looks fine to me too. Makes a lot of sense!

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Aug 18, 2016

Member

LGTM

@jekyllbot: merge +site

Member

mattr- commented Aug 18, 2016

LGTM

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 9716b57 into jekyll:master Aug 18, 2016

0 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
jekyll/lgtm Approved by @envygeeks. Requires 1 more LGTM.

jekyllbot added a commit that referenced this pull request Aug 18, 2016

@crispgm crispgm deleted the crispgm:fix-theme-highlight branch Aug 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment