New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site documentation section links always point to https://jekyllrb.com #5281

Merged
merged 1 commit into from Aug 27, 2016

Conversation

Projects
None yet
5 participants
@Anthony-Gaudino
Contributor

Anthony-Gaudino commented Aug 24, 2016

On the site documentation section, links to documentation sections always point to the jekyllrb.com website, this means that users testing changes might get confused because they will see the official external website page instead of their local website upon clicking those links.

Please check if this change doesn't break the links on the official website on https://jekyllrb.com before accepting the pull request.


@jekyll/documentation

On the site documentation section, links to documentation items point…
… to the "jekyllrb.com" website, this means that users testing changes might get confused because they will see the official external website instead of their local website upon clicking those links.
@Anthony-Gaudino

This comment has been minimized.

Show comment
Hide comment
@Anthony-Gaudino

Anthony-Gaudino Aug 24, 2016

Contributor

@jekyll/documentation

Contributor

Anthony-Gaudino commented Aug 24, 2016

@jekyll/documentation

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 24, 2016

Member

Hi..
I think there's another way around this issue. But, it requires an extra step from the testing user's end.
What they need to do is edit the url parameter inside site/_config.yml from https://jekyllrb.com to http://localhost:4000

Update: Nah. Not a good idea as _config.yml would get chucked into their PR as well.

Member

ashmaroli commented Aug 24, 2016

Hi..
I think there's another way around this issue. But, it requires an extra step from the testing user's end.
What they need to do is edit the url parameter inside site/_config.yml from https://jekyllrb.com to http://localhost:4000

Update: Nah. Not a good idea as _config.yml would get chucked into their PR as well.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 24, 2016

Member

@parkr, jekyllbot commented twice here. Once without description, then again with proper description when another user (myself) commented.
Bug?

Member

ashmaroli commented Aug 24, 2016

@parkr, jekyllbot commented twice here. Once without description, then again with proper description when another user (myself) commented.
Bug?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Aug 24, 2016

Member

I guess we could use a _development.yml config file to override _config.yml url value but I don't know how to pass a --config option to the preview task in site.rake

Member

DirtyF commented Aug 24, 2016

I guess we could use a _development.yml config file to override _config.yml url value but I don't know how to pass a --config option to the preview task in site.rake

@Anthony-Gaudino

This comment has been minimized.

Show comment
Hide comment
@Anthony-Gaudino

Anthony-Gaudino Aug 24, 2016

Contributor

Maybe the changes on this pull request won't do any harm, only the links on the documentation section have the {{ site.url }} and the changes only affect the list of links to documentation sections.

It's a good idea for someone that knows how the site is hosted to look at this pull request just to make sure this won't break the links on the official website.

Another option is to just accept the pull request and check the site after rebuild, if something is wrong, revert.

Contributor

Anthony-Gaudino commented Aug 24, 2016

Maybe the changes on this pull request won't do any harm, only the links on the documentation section have the {{ site.url }} and the changes only affect the list of links to documentation sections.

It's a good idea for someone that knows how the site is hosted to look at this pull request just to make sure this won't break the links on the official website.

Another option is to just accept the pull request and check the site after rebuild, if something is wrong, revert.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 26, 2016

Member

This works fine for me! LGTM.

/cc @jekyll/documentation

Member

parkr commented Aug 26, 2016

This works fine for me! LGTM.

/cc @jekyll/documentation

@jekyllbot jekyllbot self-assigned this Aug 26, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 27, 2016

Member

LOL, @jekyllbot. 😄

Member

parkr commented Aug 27, 2016

LOL, @jekyllbot. 😄

@parkr parkr assigned DirtyF and unassigned jekyllbot Aug 27, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 27, 2016

Member

@jekyllbot: merge +site

:shrug:

Member

parkr commented Aug 27, 2016

@jekyllbot: merge +site

:shrug:

@jekyllbot jekyllbot merged commit 1979426 into jekyll:master Aug 27, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Awaiting approval from at least 2 maintainers.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Aug 27, 2016

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Aug 27, 2016

Member

@Anthony-Gaudino it's fine on http://jekyllrb.com/ ❤️ thanks!

Member

DirtyF commented Aug 27, 2016

@Anthony-Gaudino it's fine on http://jekyllrb.com/ ❤️ thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment