New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site template: exclude Gemfile and Gemfile.lock in site config #5293

Merged
merged 1 commit into from Aug 27, 2016

Conversation

Projects
None yet
7 participants
@crispgm
Member

crispgm commented Aug 25, 2016

Gemfile and Gemfile.lock is generated after jekyll new, both of which should exclude in _config.yml. Otherwise, they can be downloaded from site.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 25, 2016

Member

Can you explain the need to explicitly exclude Gemfile and Gemfile.lock ? Gemfile.lock is generated only after bundler runs.

Member

ashmaroli commented Aug 25, 2016

Can you explain the need to explicitly exclude Gemfile and Gemfile.lock ? Gemfile.lock is generated only after bundler runs.

@crispgm

This comment has been minimized.

Show comment
Hide comment
@crispgm

crispgm Aug 25, 2016

Member

@ashmaroli Gemfile and Gemfile.lock will be served in develop mode, and be generated to destination. However, they are used by develop, not what we really want to generate to our site.

Member

crispgm commented Aug 25, 2016

@ashmaroli Gemfile and Gemfile.lock will be served in develop mode, and be generated to destination. However, they are used by develop, not what we really want to generate to our site.

@parkr

This comment has been minimized.

Show comment
Hide comment
Member

parkr commented Aug 26, 2016

LGTM.

/cc @jekyll/ecosystem

@parkr parkr assigned benbalter and unassigned parkr Aug 26, 2016

@parkr parkr added bug ux labels Aug 26, 2016

@parkr parkr changed the title from Exclude Gemfile in _config.yml template to Site template: exclude Gemfile and Gemfile.lock Aug 26, 2016

@parkr parkr changed the title from Site template: exclude Gemfile and Gemfile.lock to Site template: exclude Gemfile and Gemfile.lock in site config Aug 26, 2016

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Aug 27, 2016

Member

LGTM

@jekyllbot: merge +minor

💥

Member

mattr- commented Aug 27, 2016

LGTM

@jekyllbot: merge +minor

💥

@jekyllbot jekyllbot merged commit 4f8d855 into jekyll:master Aug 27, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Approved by @parkr. Requires 1 more LGTM.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Aug 27, 2016

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Aug 27, 2016

Member

i got the tag wrong, but ¯_(ツ)_/¯

Member

mattr- commented Aug 27, 2016

i got the tag wrong, but ¯_(ツ)_/¯

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 27, 2016

Contributor

Yeah my first few times with it I got it wrong too. It's whatever IMO.

Contributor

envygeeks commented Aug 27, 2016

Yeah my first few times with it I got it wrong too. It's whatever IMO.

@crispgm crispgm deleted the crispgm:exclude-gemfile-in-config branch Aug 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment