Site template: exclude Gemfile and Gemfile.lock in site config #5293

Merged
merged 1 commit into from Aug 27, 2016

Projects

None yet

7 participants

@crispgm
Member
crispgm commented Aug 25, 2016

Gemfile and Gemfile.lock is generated after jekyll new, both of which should exclude in _config.yml. Otherwise, they can be downloaded from site.

@crispgm crispgm Exclude Gemfile in _config.yml template
9c33754
@ashmaroli
Contributor

Can you explain the need to explicitly exclude Gemfile and Gemfile.lock ? Gemfile.lock is generated only after bundler runs.

@crispgm
Member
crispgm commented Aug 25, 2016

@ashmaroli Gemfile and Gemfile.lock will be served in develop mode, and be generated to destination. However, they are used by develop, not what we really want to generate to our site.

@parkr
Member
parkr commented Aug 26, 2016

LGTM.

/cc @jekyll/ecosystem

@parkr parkr was assigned by jekyllbot Aug 26, 2016
@parkr parkr assigned benbalter and unassigned parkr Aug 26, 2016
@parkr parkr added bug ux labels Aug 26, 2016
@parkr parkr changed the title from Exclude Gemfile in _config.yml template to Site template: exclude Gemfile and Gemfile.lock Aug 26, 2016
@parkr parkr changed the title from Site template: exclude Gemfile and Gemfile.lock to Site template: exclude Gemfile and Gemfile.lock in site config Aug 26, 2016
@mattr-
Member
mattr- commented Aug 27, 2016

LGTM

@jekyllbot: merge +minor

💥

@jekyllbot jekyllbot merged commit 4f8d855 into jekyll:master Aug 27, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Approved by @parkr. Requires 1 more LGTM.
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattr-
Member
mattr- commented Aug 27, 2016

i got the tag wrong, but ¯_(ツ)_/¯

@envygeeks
Member

Yeah my first few times with it I got it wrong too. It's whatever IMO.

@crispgm crispgm deleted the crispgm:exclude-gemfile-in-config branch Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment