New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: exclude README.md and .gitignore [ci skip] #5304

Merged
merged 1 commit into from Aug 30, 2016

Conversation

Projects
None yet
5 participants
@crispgm
Member

crispgm commented Aug 30, 2016

馃槃

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 30, 2016

Contributor

I see no reason not to. LGTM.

Contributor

envygeeks commented Aug 30, 2016

I see no reason not to. LGTM.

exclude:
- README.md
- .gitignore

This comment has been minimized.

@parkr

parkr Aug 30, 2016

Member

Interesting! This should be removed automatically.

@parkr

parkr Aug 30, 2016

Member

Interesting! This should be removed automatically.

This comment has been minimized.

@crispgm

crispgm Aug 30, 2016

Member

@parkr if these files were generated with jekyll new by default, we could add them to template of _config.yml. Repos with jekyll site have large possibilities contain such files as README.md, LICENSE, Rakefile, .gitignore, etc.

@crispgm

crispgm Aug 30, 2016

Member

@parkr if these files were generated with jekyll new by default, we could add them to template of _config.yml. Repos with jekyll site have large possibilities contain such files as README.md, LICENSE, Rakefile, .gitignore, etc.

This comment has been minimized.

@ashmaroli

ashmaroli Aug 30, 2016

Member

@crispgm, currently the files here plus a Gemfile are copied to a new site's root by jekyll new

@ashmaroli

ashmaroli Aug 30, 2016

Member

@crispgm, currently the files here plus a Gemfile are copied to a new site's root by jekyll new

This comment has been minimized.

@ashmaroli

ashmaroli Aug 30, 2016

Member

so, is there really a need to have this exclusion, by default?

update: I got the answer I needed.

@ashmaroli

ashmaroli Aug 30, 2016

Member

so, is there really a need to have this exclusion, by default?

update: I got the answer I needed.

This comment has been minimized.

@parkr

parkr Aug 30, 2016

Member

@crispgm Yes! I mean that Jekyll should ignore it when building. See EntryFilter.

@parkr

parkr Aug 30, 2016

Member

@crispgm Yes! I mean that Jekyll should ignore it when building. See EntryFilter.

This comment has been minimized.

@crispgm

crispgm Aug 31, 2016

Member

@parkr sounds that .gitignore should be exclude by EntryFilter. I will inspect this later.

@crispgm

crispgm Aug 31, 2016

Member

@parkr sounds that .gitignore should be exclude by EntryFilter. I will inspect this later.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 30, 2016

Member

LGTM.

Member

parkr commented Aug 30, 2016

LGTM.

@parkr parkr added the documentation label Aug 30, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 30, 2016

Contributor

@jekyllbot: merge +site

Contributor

envygeeks commented Aug 30, 2016

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 095d534 into jekyll:master Aug 30, 2016

1 check passed

jekyll/lgtm Approved by @envygeeks and @parkr.

jekyllbot added a commit that referenced this pull request Aug 30, 2016

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 30, 2016

Member

@DirtyF, I cant find the documentation that explains the principle behind the exclude array in a _config.yml. Please help.

Member

ashmaroli commented Aug 30, 2016

@DirtyF, I cant find the documentation that explains the principle behind the exclude array in a _config.yml. Please help.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 30, 2016

Contributor

@ashmaroli the exclude array prevents a file from being written. So say you don't want your Gemfile, or README.md or vendor/ folder to end up being processed, you exclude them and they aren't processed or written. On a side note: I just seen your comment, sorry I merged before we talked about what you wanted to talk about.

See: https://jekyllrb.com/docs/configuration/#global-configuration

Contributor

envygeeks commented Aug 30, 2016

@ashmaroli the exclude array prevents a file from being written. So say you don't want your Gemfile, or README.md or vendor/ folder to end up being processed, you exclude them and they aren't processed or written. On a side note: I just seen your comment, sorry I merged before we talked about what you wanted to talk about.

See: https://jekyllrb.com/docs/configuration/#global-configuration

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 30, 2016

Member

On a side note: I just seen your comment, sorry I merged before we talked about what you wanted to talk about.

@envygeeks Thats alright, nothing serious, simply wondering aloud.
Thanks for the answer to my query.

Member

ashmaroli commented Aug 30, 2016

On a side note: I just seen your comment, sorry I merged before we talked about what you wanted to talk about.

@envygeeks Thats alright, nothing serious, simply wondering aloud.
Thanks for the answer to my query.

@crispgm crispgm deleted the crispgm:site-exclude branch Aug 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment