New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add help for missing static_file e.g. on heroku #5334

Merged
merged 1 commit into from Sep 7, 2016

Conversation

Projects
None yet
7 participants
@Crunch09
Member

Crunch09 commented Sep 6, 2016

Hi,
as described in #5144 somehow on Heroku a bin/erb file couldn't be found during build. This was a symlinked file and it couldn't be copied because of the reasons @parkr pointed out in #4640 (comment) .
I wasn't sure if i should also rescue the exception in the static_file.rb and provide a better error message in the log, so for now there is only a new section in the troubleshooting doc.

I would be glad if @xuanxu and / or @stomar could confirm if their site is building again after they set their jekyll environment to production.

cc: @jekyll/documentation

screen shot 2016-09-06 at 22 54 20

Show outdated Hide outdated site/_docs/troubleshooting.md
If you run into an issue that a static file can't be found in your
production environment during build since v3.2.0 you should set your
[environment to `production`](https://jekyllrb.com/docs/configuration/#specifying-a-jekyll-environment-at-build-time).

This comment has been minimized.

@DirtyF

DirtyF Sep 6, 2016

Member

Could we use relative link here instead please? (../configuration/#specifying-a-jekyll-environment-at-build-time) Thanks.

@DirtyF

DirtyF Sep 6, 2016

Member

Could we use relative link here instead please? (../configuration/#specifying-a-jekyll-environment-at-build-time) Thanks.

This comment has been minimized.

@Crunch09

Crunch09 Sep 7, 2016

Member

Thanks! Updated it.

@Crunch09

Crunch09 Sep 7, 2016

Member

Thanks! Updated it.

This comment has been minimized.

@envygeeks

envygeeks Sep 7, 2016

Contributor

I agree with removing the domain but I don't get the logic behind a relative link? Unless Jekyll has some magic that makes these absolute they should be absolute, having links relative makes it hard to change the name of a page and while it might be rare it can happen and this makes that move more expensive than it ever should be.

@envygeeks

envygeeks Sep 7, 2016

Contributor

I agree with removing the domain but I don't get the logic behind a relative link? Unless Jekyll has some magic that makes these absolute they should be absolute, having links relative makes it hard to change the name of a page and while it might be rare it can happen and this makes that move more expensive than it ever should be.

This comment has been minimized.

@DirtyF

DirtyF Sep 7, 2016

Member

@envygeeks Got it. I'll open another PR to fix this globally, because there are already some relative links elsewhere in the docs.

@DirtyF

DirtyF Sep 7, 2016

Member

@envygeeks Got it. I'll open another PR to fix this globally, because there are already some relative links elsewhere in the docs.

@xuanxu

This comment has been minimized.

Show comment
Hide comment
@xuanxu

xuanxu Sep 7, 2016

Confirmed, that solved the issue for me, I set the JEKYLL_ENV to production in heroku and build was successfull. Thanks @Crunch09!

xuanxu commented Sep 7, 2016

Confirmed, that solved the issue for me, I set the JEKYLL_ENV to production in heroku and build was successfull. Thanks @Crunch09!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 7, 2016

Member

LGTM.

Member

parkr commented Sep 7, 2016

LGTM.

@parkr parkr added the documentation label Sep 7, 2016

@parkr parkr unassigned DirtyF and parkr Sep 7, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 7, 2016

Member

@jekyllbot: merge +site

Member

parkr commented Sep 7, 2016

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 57ab7c5 into jekyll:master Sep 7, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Approved by @parkr. Requires 1 more LGTM.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Sep 7, 2016

@stomar

This comment has been minimized.

Show comment
Hide comment
@stomar

stomar Sep 8, 2016

Contributor

IMO the description is a bit unclear. It's not specifically a production problem but rather a problem for possibly any site with symlinks that break when copied elsewhere (namely to _site), e.g. relative symlinks to files outside the site's directory. Building such a site in a non-production JEKYLL_ENV environment (e.g. development) fails, because the symlinks are copied as symlinks and the target can not be found.

On Heroku this happens also for sites without any symlinks, since Heroku seems to add some.

@envygeeks The statement in #5144 that this problem is caused by 0f74db4 is wrong; I did some further tests and wanted to add a corresponding comment there, but the issue is locked now (why?!?).
Could you please unlock?

Contributor

stomar commented Sep 8, 2016

IMO the description is a bit unclear. It's not specifically a production problem but rather a problem for possibly any site with symlinks that break when copied elsewhere (namely to _site), e.g. relative symlinks to files outside the site's directory. Building such a site in a non-production JEKYLL_ENV environment (e.g. development) fails, because the symlinks are copied as symlinks and the target can not be found.

On Heroku this happens also for sites without any symlinks, since Heroku seems to add some.

@envygeeks The statement in #5144 that this problem is caused by 0f74db4 is wrong; I did some further tests and wanted to add a corresponding comment there, but the issue is locked now (why?!?).
Could you please unlock?

@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Sep 8, 2016

Member

@stomar Yes, you're right, the issue was introduced by #4640

Member

Crunch09 commented Sep 8, 2016

@stomar Yes, you're right, the issue was introduced by #4640

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 8, 2016

Contributor

@stomar @Crunch09 my bot locks issues when people do "👍" or "I have this issue too" (or the like.) It is unlocked now so that you can continue the discussion, and yes my bot probably was wrong, it was just in the beginning phases of being able to do blames.

Contributor

envygeeks commented Sep 8, 2016

@stomar @Crunch09 my bot locks issues when people do "👍" or "I have this issue too" (or the like.) It is unlocked now so that you can continue the discussion, and yes my bot probably was wrong, it was just in the beginning phases of being able to do blames.

@Crunch09 Crunch09 deleted the Crunch09:issue-5144 branch Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment