Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added path in url. #536
Page#dir was returning the wrong dir ('/') for pages in directories.
Also #url was returning the wrong path for pages in directories.
Actually I wrote a fix and the tests but then I saw the list of 49 (!) pending pull requests and went through the list to find if anyone else was having the same problem. Issue #506 was a similar solution to mine but a bit cleaner and decided to use MrWerewolf's soluaion but with the tests I have already written.
Some credit should be given to MrWerewolf.
referenced this pull request
Apr 9, 2012
@mattr- thanks for your comment! If you look at the context above the tests I added, it uses the same format: "write properly [...]". So I decided to go with the flow and respect the file conventions even tho they don't spell out properly (they also don't spell out properly above as well).
Well, is changing a test description going to land this into master? If you are so positive about this, then I'll go ahead and update the PR.
Hey @parkr thanks for your feedback!
First things first, I meant absolutely no disrespect, nor did I imply that you guys are slow at responding to pull requests or anything. Sorry if it sounded that way! All I wanted to say was that a year has passed... I didn't even remember this pull request existed, nor how it fixed the issue at hand and I had to sift through this old code again to understand how it worked, which is not always a pleasant thing (as I guess you already know). I was positively surprised that there was interest for this PR after a year!
I updated the tests, per the above discovery and investigation, and made some changes in
Thanks for looking into this. Really appreciated!