New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added path in url. #536
Merged
Merged
Added path in url. #536
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
title: Contact Information | ||
--- | ||
|
||
Contact Information |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
title: Contact Information | ||
--- | ||
|
||
Contact Information |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test assertion doesn't have the trailing
/
while the previous one doesn't. What's up with that? Why wouldn't an index page also deserve this trailing slash?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parkr well it's been almost a year (wow... 11 months ago) since I submitted this. 😄
OK, I dug through the code again. Nice catch! But it doesn't seem to matter since this is the directory where the file / page will be put into and not a (pretty) URL.
It appears it's not related to this commit but it just surfaced from the tests. The "issue" lies within
#dir
.For example when the URL is
/contacts/index.html
, it doesn't end with a slash andFile#basename
returns/contacts
. When the URL is/contacts/bar/
it ends with a URL and the dir is returned as is (same at the URL).Honestly I'm more concerned with the "A Page processing pages with pretty url style in a directory hierarchy should create url based on filename" test which should return "/contacts/" as the pretty URL for the index file in a directory.
I will investigate this a bit more when I get home. Looks like that
#dir
and/or#template
might have to be changed a bit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you find out.
In terms of the wait, I have only been a moderator for two months and I think I've done a pretty good job of dealing with crucial issues. I look at every notification from this repo. Once it's convincing enough, I'll accept it. You can expect more responsiveness from me.