New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude vendor by default #5361

Merged
merged 2 commits into from Sep 16, 2016

Conversation

Projects
None yet
8 participants
@DirtyF
Member

DirtyF commented Sep 16, 2016

Fix #5359

  • Update documentation

cc/ @jekyll/core

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Sep 16, 2016

Member

LGTM.

Member

mattr- commented Sep 16, 2016

LGTM.

@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Sep 16, 2016

Member

Do we need to document this somewhere?

Linking #5210 because excluding vendor was also mentioned in there.

Member

Crunch09 commented Sep 16, 2016

Do we need to document this somewhere?

Linking #5210 because excluding vendor was also mentioned in there.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Sep 16, 2016

Member

@Crunch09 you're right, we have to mention it in https://jekyllrb.com/docs/configuration/#default-configuration

https://jekyllrb.com/docs/troubleshooting/#configuration-problems might still be useful for those who doesn't run latest Jekyll.

Member

DirtyF commented Sep 16, 2016

@Crunch09 you're right, we have to mention it in https://jekyllrb.com/docs/configuration/#default-configuration

https://jekyllrb.com/docs/troubleshooting/#configuration-problems might still be useful for those who doesn't run latest Jekyll.

@parkr

parkr approved these changes Sep 16, 2016

LGTM. We should note that these are overwritten when you specify any excludes in your configuration.

@envygeeks

LGTM.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 16, 2016

Member

@jekyllbot: merge +minor

Member

parkr commented Sep 16, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit c877d6f into jekyll:master Sep 16, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Awaiting approval from at least 2 maintainers.
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Sep 16, 2016

@DirtyF DirtyF deleted the DirtyF:patch-1 branch Sep 16, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 16, 2016

Contributor

❤️ so much for this. It'll be such relief not to build a new Jekyll site and have it fail the first build only for me to remember to add vendor/bundle to the list of excludes.

Contributor

envygeeks commented Sep 16, 2016

❤️ so much for this. It'll be such relief not to build a new Jekyll site and have it fail the first build only for me to remember to add vendor/bundle to the list of excludes.

@just-boris

This comment has been minimized.

Show comment
Hide comment
@just-boris

just-boris Nov 15, 2016

This is breaking change!

I had a repo on Github with gh-pages, that contains some file and also a vendor dir with some third-party libraries. Today I tried to update that project and it had been broken.

Finally, I have figured out that vendor dir is ignored by default now, but that was very sudden, there was no announce, that here will be new default options, and users should check their pages.

just-boris commented Nov 15, 2016

This is breaking change!

I had a repo on Github with gh-pages, that contains some file and also a vendor dir with some third-party libraries. Today I tried to update that project and it had been broken.

Finally, I have figured out that vendor dir is ignored by default now, but that was very sudden, there was no announce, that here will be new default options, and users should check their pages.

just-boris added a commit to just-boris/meteo that referenced this pull request Nov 15, 2016

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 15, 2016

Member

This has been patched with v3.3.1 Now only a few specific sub-directories inside vendor are ignored. Github-Pages gem will be updated soon to fix this issue.

/cc @benbalter

Member

ashmaroli commented Nov 15, 2016

This has been patched with v3.3.1 Now only a few specific sub-directories inside vendor are ignored. Github-Pages gem will be updated soon to fix this issue.

/cc @benbalter

@DirtyF DirtyF referenced this pull request Jun 9, 2017

Closed

Can't build new site. #6127

5 of 17 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment