Exclude vendor by default #5361

Merged
merged 2 commits into from Sep 16, 2016

Projects

None yet

8 participants

@DirtyF
Member
DirtyF commented Sep 16, 2016 edited

Fix #5359

  • Update documentation

cc/ @jekyll/core

@DirtyF DirtyF Exclude vendor by default
59b61c3
@mattr-
Member
mattr- commented Sep 16, 2016

LGTM.

@Crunch09
Member

Do we need to document this somewhere?

Linking #5210 because excluding vendor was also mentioned in there.

@DirtyF
Member
DirtyF commented Sep 16, 2016 edited

@Crunch09 you're right, we have to mention it in https://jekyllrb.com/docs/configuration/#default-configuration

https://jekyllrb.com/docs/troubleshooting/#configuration-problems might still be useful for those who doesn't run latest Jekyll.

@DirtyF DirtyF vendor is now excluded by default [ci-skip]
0233d93
@parkr
parkr approved these changes Sep 16, 2016 View changes

LGTM. We should note that these are overwritten when you specify any excludes in your configuration.

@envygeeks

LGTM.

@parkr
Member
parkr commented Sep 16, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit c877d6f into jekyll:master Sep 16, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
jekyll/lgtm Awaiting approval from at least 2 maintainers.
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DirtyF DirtyF deleted the DirtyF:patch-1 branch Sep 16, 2016
@envygeeks
Member

❤️ so much for this. It'll be such relief not to build a new Jekyll site and have it fail the first build only for me to remember to add vendor/bundle to the list of excludes.

@just-boris

This is breaking change!

I had a repo on Github with gh-pages, that contains some file and also a vendor dir with some third-party libraries. Today I tried to update that project and it had been broken.

Finally, I have figured out that vendor dir is ignored by default now, but that was very sudden, there was no announce, that here will be new default options, and users should check their pages.

@just-boris just-boris added a commit to just-boris/meteo that referenced this pull request Nov 15, 2016
@just-boris just-boris move third-party code into deps folder 6f8d216
@ashmaroli
Contributor

This has been patched with v3.3.1 Now only a few specific sub-directories inside vendor are ignored. Github-Pages gem will be updated soon to fix this issue.

/cc @benbalter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment