New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appease Rubocop #5381

Merged
merged 1 commit into from Sep 20, 2016

Conversation

Projects
None yet
4 participants
@pathawks
Member

pathawks commented Sep 19, 2016

Rubocop 0.43.0 seems to have some new expectations.

rubocop -a

@envygeeks

LGTM.

@@ -54,7 +54,7 @@ def self.register(owners, event, priority: DEFAULT_PRIORITY, &block)
# Ensure the priority is a Fixnum

This comment has been minimized.

@pathawks

pathawks Sep 20, 2016

Member

Should I replace Fixnum with Integer in this comment too?

@pathawks

pathawks Sep 20, 2016

Member

Should I replace Fixnum with Integer in this comment too?

This comment has been minimized.

@envygeeks

envygeeks Sep 20, 2016

Contributor

Technically it's still right regardless, it's up to you at that point tbh.

@envygeeks

envygeeks Sep 20, 2016

Contributor

Technically it's still right regardless, it's up to you at that point tbh.

@parkr

parkr approved these changes Sep 20, 2016

Nailed it! Thank you!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 20, 2016

Member

@jekyllbot: merge +dev

Member

parkr commented Sep 20, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit d8d42f6 into jekyll:master Sep 20, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Sep 20, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 20, 2016

Member

FWIW the thing about 10 being in the filename was a false positive. Tracked in rubocop-hq/rubocop#3514.

Member

parkr commented Sep 20, 2016

FWIW the thing about 10 being in the filename was a false positive. Tracked in rubocop-hq/rubocop#3514.

parkr added a commit that referenced this pull request Sep 20, 2016

Merge branch 'master' into themes-asset-folder
* master:
  Update history to reflect merge of #5381 [ci skip]
  Update history to reflect merge of #5383 [ci skip]
  run features on windows
  Appease Rubocop
  Update history to reflect merge of #5372 [ci skip]
  Add missing period to sentence in first paragraph.

@pathawks pathawks deleted the pathawks:pr/rubocop branch Sep 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment