New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run executable for Cucumber via Ruby instead of Shell #5383

Merged
merged 1 commit into from Sep 20, 2016

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Sep 20, 2016

Since Windows does not recognize exe/jekyll as an executable, let ruby run it instead of having shell do it. This moves us a step closer to fixing cucumber test scenarios on Windows.

Ref: #5241

Earlier, every cucumber scenario would fail prematurely with following:

  Exec format error - C:/projects/jekyll/exe/jekyll (Errno::ENOEXEC)
  C:/projects/jekyll/features/support/helpers.rb:101:in `run_in_shell'
  C:/projects/jekyll/features/support/helpers.rb:93:in `run_jekyll'
  C:/projects/jekyll/features/step_definitions.rb:141:in `/^I run jekyll(.*)$/'
  <features/*.feature:LN#>:in `When I run jekyll build'

/cc @jekyll/windows

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Sep 20, 2016

Contributor

LGTM as far as I can tell; I see more steps pass with this change.

Contributor

XhmikosR commented Sep 20, 2016

LGTM as far as I can tell; I see more steps pass with this change.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 20, 2016

Member

yes true.
comparing now:

201 scenarios (201 failed)
1638 steps (7 failed, 2 skipped, 1629 passed)

with earlier

201 scenarios (201 failed)
1638 steps (201 failed, 720 skipped, 717 passed)
Member

ashmaroli commented Sep 20, 2016

yes true.
comparing now:

201 scenarios (201 failed)
1638 steps (7 failed, 2 skipped, 1629 passed)

with earlier

201 scenarios (201 failed)
1638 steps (201 failed, 720 skipped, 717 passed)
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 20, 2016

Member

LGTM, thank you!

@jekyllbot: merge +dev

Member

parkr commented Sep 20, 2016

LGTM, thank you!

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 2eedf7d into jekyll:master Sep 20, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@parkr parkr added the windows label Sep 20, 2016

jekyllbot added a commit that referenced this pull request Sep 20, 2016

parkr added a commit that referenced this pull request Sep 20, 2016

Merge branch 'master' into themes-asset-folder
* master:
  Update history to reflect merge of #5381 [ci skip]
  Update history to reflect merge of #5383 [ci skip]
  run features on windows
  Appease Rubocop
  Update history to reflect merge of #5372 [ci skip]
  Add missing period to sentence in first paragraph.

@ashmaroli ashmaroli deleted the ashmaroli:ruby-cucumber branch Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment