Skip to content
This repository

Update and fix Redcarpet #539

Closed
wants to merge 2 commits into from

5 participants

Cody Krieger Postmodern José Mota Sindre Sorhus Tom Preston-Werner
Cody Krieger

Updated Redcarpet, fixed the converter, and fixed the appropriate test.

Postmodern

Also ran into this:

/home/hal/.rvm/gems/ruby-1.9.3-p194/gems/jekyll-0.11.2/lib/jekyll/converters/markdown.rb:91:in `convert': undefined method `new' for Redcarpet:Module (NoMethodError)
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/gems/jekyll-0.11.2/lib/jekyll/convertible.rb:46:in `transform'
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/gems/jekyll-0.11.2/lib/jekyll/convertible.rb:84:in `do_layout'
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/gems/jekyll-0.11.2/lib/jekyll/post.rb:189:in `render'
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/gems/jekyll-0.11.2/lib/jekyll/site.rb:193:in `block in render'
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/gems/jekyll-0.11.2/lib/jekyll/site.rb:192:in `each'
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/gems/jekyll-0.11.2/lib/jekyll/site.rb:192:in `render'
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/gems/jekyll-0.11.2/lib/jekyll/site.rb:40:in `process'
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/gems/jekyll-0.11.2/bin/jekyll:250:in `'
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/bin/jekyll:19:in `load'
    from /home/hal/.rvm/gems/ruby-1.9.3-p194/bin/jekyll:19:in `'
Deleted user
ghost commented May 02, 2012

The content you are editing has changed. Reload the page and try again.

same problem
markdown.rb:91:in convert': undefined methodnew' for Redcarpet:Module (NoMethodError)

Sending Request…

Attach images by dragging & dropping or selecting them. Octocat-spinner-32 Uploading your images… Unfortunately, we don't support that file type. Try again with a PNG, GIF, or JPG. Yowza, that's a big file. Try again with an image file smaller than 10MB. This browser doesn't support image attachments. We recommend updating to the latest Internet Explorer, Google Chrome, or Firefox. Something went really wrong, and we can't process that image. Try again.

José Mota

+1
Latest version, freshly downloaded.

Sindre Sorhus

Duplicate of #450

Tom Preston-Werner
Owner

Fixed and closed by #619.

Tom Preston-Werner mojombo closed this December 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 2 unique commits by 1 author.

Apr 13, 2012
Cody Krieger Fix Redcarpet. eaa5ebb
Cody Krieger Fix Redcarpet test. 53418e5
This page is out of date. Refresh to see the latest.
2  jekyll.gemspec
@@ -37,7 +37,7 @@ Gem::Specification.new do |s|
37 37
   s.add_development_dependency('cucumber', "1.1")
38 38
   s.add_development_dependency('RedCloth', "~> 4.2")
39 39
   s.add_development_dependency('rdiscount', "~> 1.6")
40  
-  s.add_development_dependency('redcarpet', "~> 1.9")
  40
+  s.add_development_dependency('redcarpet', "~> 2.1.1")
41 41
   
42 42
   # = MANIFEST =
43 43
   s.files = %w[
2  lib/jekyll/converters/markdown.rb
@@ -88,7 +88,7 @@ def convert(content)
88 88
       setup
89 89
       case @config['markdown']
90 90
         when 'redcarpet'
91  
-          Redcarpet.new(content, *@redcarpet_extensions).to_html
  91
+          RedcarpetCompat.new(content, *@redcarpet_extensions).to_html
92 92
         when 'kramdown'
93 93
           # Check for use of coderay
94 94
           if @config['kramdown']['use_coderay']
2  test/test_redcarpet.rb
@@ -15,7 +15,7 @@ class TestRedcarpet < Test::Unit::TestCase
15 15
     end
16 16
     
17 17
     should "pass redcarpet extensions" do
18  
-      assert_equal "<p>&ldquo;smart&rdquo;</p>", @markdown.convert('"smart"').strip
  18
+      assert_equal "<p>&quot;smart&quot;</p>", @markdown.convert('"smart"').strip
19 19
     end
20 20
   end
21 21
 end
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.