New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for relative_url and absolute_url #5405

Merged
merged 1 commit into from Sep 24, 2016

Conversation

Projects
None yet
5 participants
@parkr
Member

parkr commented Sep 23, 2016

@benbalter @pathawks I can't believe I forgot this! Follow-up to #5399 for documentation.

screen shot 2016-09-23 at 2 27 23 pm

@parkr parkr referenced this pull request Sep 23, 2016

Closed

Jekyll 3.3 Release Gameplan #5400

9 of 9 tasks complete

@parkr parkr added the documentation label Sep 23, 2016

@parkr parkr added this to the 3.3 milestone Sep 23, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 24, 2016

Member

Oh! Forgot to /cc @jekyll/documentation on this. Slated for Jekyll 3.3.

Member

parkr commented Sep 24, 2016

Oh! Forgot to /cc @jekyll/documentation on this. Slated for Jekyll 3.3.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 24, 2016

Member

@jekyllbot: merge +site

Member

parkr commented Sep 24, 2016

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 5c55d95 into master Sep 24, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the relative_url_and_absolute_url branch Sep 24, 2016

jekyllbot added a commit that referenced this pull request Sep 24, 2016

@QXSoftware

This comment has been minimized.

Show comment
Hide comment
@QXSoftware

QXSoftware Nov 20, 2016

The absolute_url is good, but it can only return http url. What about a https absolute_url ?

QXSoftware commented Nov 20, 2016

The absolute_url is good, but it can only return http url. What about a https absolute_url ?

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 20, 2016

Member

The absolute_url is good, but it can only return http url. What about a https absolute_url?

I'm not sure I understand. When does it not return an https url?

Member

pathawks commented Nov 20, 2016

The absolute_url is good, but it can only return http url. What about a https absolute_url?

I'm not sure I understand. When does it not return an https url?

@QXSoftware

This comment has been minimized.

Show comment
Hide comment
@QXSoftware

QXSoftware Nov 21, 2016

I finally realized that in my _config.yml, I put an http url in it, so change it to a https one will fix this problem 😃

- url: "http://www.example.com"
+ url: "https://www.example.com"

QXSoftware commented Nov 21, 2016

I finally realized that in my _config.yml, I put an http url in it, so change it to a https one will fix this problem 😃

- url: "http://www.example.com"
+ url: "https://www.example.com"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment