New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig #5412

Merged
merged 1 commit into from Sep 29, 2016

Conversation

Projects
None yet
3 participants
@zdroid
Member

zdroid commented Sep 24, 2016

As suggested in jekyll/minima#44 discussion.

Humans make mistakes, that's simple. It's easy to prevent the most common mistakes with adding one standardized file of 14 lines.

Another editorconfig-related thread: jekyll/jekyll#3527

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 28, 2016

Member

The reason we originally rejected this was because it isn't standard – it's a plugin for everything. Ir reminds me of this comic. It's hard to actually enforce. We have rubocop checks for this now. I accepted it into jekyll/minima because it doesn't have any checks like we have here with rubocop.

I'm ambivalent. Does anyone in @jekyll/core have a strong preference?

Member

parkr commented Sep 28, 2016

The reason we originally rejected this was because it isn't standard – it's a plugin for everything. Ir reminds me of this comic. It's hard to actually enforce. We have rubocop checks for this now. I accepted it into jekyll/minima because it doesn't have any checks like we have here with rubocop.

I'm ambivalent. Does anyone in @jekyll/core have a strong preference?

@zdroid

This comment has been minimized.

Show comment
Hide comment
@zdroid

zdroid Sep 29, 2016

Member

It is hard to be enforced to all users, but trust me, it'd help a lot. Myriad projects tried it out and it works fine. Atom, Brackets and Sublime support it, and they're surely the three most used code editors in the GitHub community.

Member

zdroid commented Sep 29, 2016

It is hard to be enforced to all users, but trust me, it'd help a lot. Myriad projects tried it out and it works fine. Atom, Brackets and Sublime support it, and they're surely the three most used code editors in the GitHub community.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 29, 2016

Member

Ok, we'll tweak it if it starts to interfere with any rubocop rules.

@jekyllbot: merge +dev

Member

parkr commented Sep 29, 2016

Ok, we'll tweak it if it starts to interfere with any rubocop rules.

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 54927d6 into jekyll:master Sep 29, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Sep 29, 2016

@zdroid zdroid deleted the zdroid:editorconfig branch Sep 29, 2016

@zdroid

This comment has been minimized.

Show comment
Hide comment
@zdroid

zdroid Sep 29, 2016

Member

Glad to hear that. 👍

Member

zdroid commented Sep 29, 2016

Glad to hear that. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment