New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis.ci documentation #5413

Merged
merged 2 commits into from Sep 28, 2016

Conversation

Projects
None yet
6 participants
@tf2manu994
Contributor

tf2manu994 commented Sep 25, 2016

You can see that without this fix, it crashes and burns.

Gem::InstallError: activesupport requires Ruby version >= 2.2.2.

Which is a dependency.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 25, 2016

Member

Jekyll doesn't depend on activesupport-5+ actually.

/cc @jekyll/documentation

Member

ashmaroli commented Sep 25, 2016

Jekyll doesn't depend on activesupport-5+ actually.

/cc @jekyll/documentation

@tf2manu994

This comment has been minimized.

Show comment
Hide comment
@tf2manu994

tf2manu994 Sep 25, 2016

Contributor

@ashmaroli html-proofer does though.

$ gem install html-proofer
Fetching: concurrent-ruby-1.0.2.gem (100%)
Successfully installed concurrent-ruby-1.0.2
Fetching: minitest-5.9.0.gem (100%)
Successfully installed minitest-5.9.0
Fetching: thread_safe-0.3.5.gem (100%)
Successfully installed thread_safe-0.3.5
Fetching: tzinfo-1.2.2.gem (100%)
Successfully installed tzinfo-1.2.2
Fetching: i18n-0.7.0.gem (100%)
Successfully installed i18n-0.7.0
Fetching: activesupport-5.0.0.1.gem (100%)
ERROR:  Error installing html-proofer:
    activesupport requires Ruby version >= 2.2.2.
Contributor

tf2manu994 commented Sep 25, 2016

@ashmaroli html-proofer does though.

$ gem install html-proofer
Fetching: concurrent-ruby-1.0.2.gem (100%)
Successfully installed concurrent-ruby-1.0.2
Fetching: minitest-5.9.0.gem (100%)
Successfully installed minitest-5.9.0
Fetching: thread_safe-0.3.5.gem (100%)
Successfully installed thread_safe-0.3.5
Fetching: tzinfo-1.2.2.gem (100%)
Successfully installed tzinfo-1.2.2
Fetching: i18n-0.7.0.gem (100%)
Successfully installed i18n-0.7.0
Fetching: activesupport-5.0.0.1.gem (100%)
ERROR:  Error installing html-proofer:
    activesupport requires Ruby version >= 2.2.2.
@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 25, 2016

Member

I saw that too..
jekyll doesnt directly require html-proofer to be installed either.. That gem recently released a new version that depended on a higher version of activesupport.
I cant see why jekyll documentation has to be altered for that change...

Update: Since, this doc in particular concerns Continuous Integration, I concede that either we advocate html-proofer < 3.1. or advice rvm bumped to min 2.2.2..
So.. 👍

Member

ashmaroli commented Sep 25, 2016

I saw that too..
jekyll doesnt directly require html-proofer to be installed either.. That gem recently released a new version that depended on a higher version of activesupport.
I cant see why jekyll documentation has to be altered for that change...

Update: Since, this doc in particular concerns Continuous Integration, I concede that either we advocate html-proofer < 3.1. or advice rvm bumped to min 2.2.2..
So.. 👍

Change to 2.2.5 instead of 2.2.2
We don't need 2.2.2 exactly, switching to 2.2.5 shaves a solid 30 seconds off build time, as it is preinstalled on travis
@tf2manu994

This comment has been minimized.

Show comment
Hide comment
@tf2manu994

tf2manu994 Sep 26, 2016

Contributor

Updated to shave some time off build if that was the concern

Contributor

tf2manu994 commented Sep 26, 2016

Updated to shave some time off build if that was the concern

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 26, 2016

Member

shave some time off build

Please explain more..

Member

ashmaroli commented Sep 26, 2016

shave some time off build

Please explain more..

@tf2manu994

This comment has been minimized.

Show comment
Hide comment
@tf2manu994

tf2manu994 Sep 26, 2016

Contributor

I assumed the reason we were using the older version of ruby was to take advantage of the fact that it was preinstalled on Travis. Travis already preinstalls 2.2.5, so it's more efficient to install 2.2.5 than 2.2.2

Contributor

tf2manu994 commented Sep 26, 2016

I assumed the reason we were using the older version of ruby was to take advantage of the fact that it was preinstalled on Travis. Travis already preinstalls 2.2.5, so it's more efficient to install 2.2.5 than 2.2.2

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Sep 26, 2016

Member

Please bear in mind that according to https://pages.github.com/versions/ ruby version is still 2.1 for GitHub Pages.

@tf2manu994 Sorry I misread you change, as long as docs are concerned I am fine with this.

Member

DirtyF commented Sep 26, 2016

Please bear in mind that according to https://pages.github.com/versions/ ruby version is still 2.1 for GitHub Pages.

@tf2manu994 Sorry I misread you change, as long as docs are concerned I am fine with this.

@tf2manu994

This comment has been minimized.

Show comment
Hide comment
@tf2manu994

tf2manu994 Sep 26, 2016

Contributor

If we're going by that, should we not use the github-pages gem?

Contributor

tf2manu994 commented Sep 26, 2016

If we're going by that, should we not use the github-pages gem?

peternewman added a commit to peternewman/pidcodes.github.com that referenced this pull request Sep 28, 2016

@peternewman

This comment has been minimized.

Show comment
Hide comment
@peternewman

peternewman Sep 28, 2016

It looks like it needs a note in the .travis.yml to update the docs when the Travis config is updated.

peternewman commented Sep 28, 2016

It looks like it needs a note in the .travis.yml to update the docs when the Travis config is updated.

@parkr

parkr approved these changes Sep 28, 2016

@parkr parkr added the documentation label Sep 28, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 28, 2016

Member

@jekyllbot: merge +dev

Member

parkr commented Sep 28, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 8138e67 into jekyll:master Sep 28, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Sep 28, 2016

parkr added a commit that referenced this pull request Sep 28, 2016

Arachnid added a commit to pidcodes/pidcodes.github.com that referenced this pull request Oct 2, 2016

Enable initial Travis CI workflow (#183)
* Remove errant .DS_Store file

* Ignore .DS_Store

* Create a list of organisations

* Add an org list

* Show number of PIDs per org

* Fix HTML issue, sort orgs by title

* Try and fix the PID count

* Try and fix issues

* Try again to fix issues

* Try yet again to fix issues

* Correct the urlpart

* Change to sort_natural, minor code tidy

* Try and fix the sorting

* Try again to fix the sorting

* Remove debugging

* Add a link to orgs page

* Install dependencies for Travis

* Create .travis.yml

* Add the Travis script

* Update the Ruby version

* Bump the Ruby version some more

* Switch back to the documented version

* Add the exclude

* Update based on jekyll/jekyll#5413

* Add github-pages Gem

* Add missing gems

* Add redcarpet

* Switch to tasks so we can run multiple CI tasks

* Switch to tasks

* Fix the matrix

* More matrix fixing

* Turn on more htmlproofer options

* Make the check less strict

* Don't bother complaining about extra jekyll tags

* Escape HTML entities

* Fix the email link

* Fix the link within the 404 page!

* Escape more HTML entities

* Remove an invalid site URL

* Cache ruby bundles

* Escape even more HTML entities

* Escape yet more HTML entities

* Escape more HTML entities and switch to a div

* Try and fix the errant paragraph item

* Add a Travis badge to the readme

* Update Gemfile

Adapted from https://github.com/lunaryorn/lunaryorn.github.io

* Update _config.yml

* Add some more checks to Travis

* Report GH Pages versions

* Tidy up, add redcarpet back in

* Try and stop the spurious paragraph tags

Arachnid added a commit to pidcodes/pidcodes.github.com that referenced this pull request Oct 12, 2016

Check Open Graph via html-proofer (#185)
* Remove errant .DS_Store file

* Ignore .DS_Store

* Create a list of organisations

* Add an org list

* Show number of PIDs per org

* Fix HTML issue, sort orgs by title

* Try and fix the PID count

* Try and fix issues

* Try again to fix issues

* Try yet again to fix issues

* Correct the urlpart

* Change to sort_natural, minor code tidy

* Try and fix the sorting

* Try again to fix the sorting

* Remove debugging

* Add a link to orgs page

* Install dependencies for Travis

* Create .travis.yml

* Add the Travis script

* Update the Ruby version

* Bump the Ruby version some more

* Switch back to the documented version

* Add the exclude

* Update based on jekyll/jekyll#5413

* Add github-pages Gem

* Add missing gems

* Add redcarpet

* Switch to tasks so we can run multiple CI tasks

* Switch to tasks

* Fix the matrix

* More matrix fixing

* Turn on more htmlproofer options

* Make the check less strict

* Don't bother complaining about extra jekyll tags

* Escape HTML entities

* Fix the email link

* Fix the link within the 404 page!

* Escape more HTML entities

* Remove an invalid site URL

* Cache ruby bundles

* Escape even more HTML entities

* Escape yet more HTML entities

* Escape more HTML entities and switch to a div

* Try and fix the errant paragraph item

* Add a Travis badge to the readme

* Update Gemfile

Adapted from https://github.com/lunaryorn/lunaryorn.github.io

* Update _config.yml

* Add some more checks to Travis

* Report GH Pages versions

* Tidy up, add redcarpet back in

* Try and stop the spurious paragraph tags

* Check Open Graph

Arachnid added a commit to pidcodes/pidcodes.github.com that referenced this pull request Oct 21, 2016

Make pid.codes an internal domain for htmlproofer (#190)
* Remove errant .DS_Store file

* Ignore .DS_Store

* Create a list of organisations

* Add an org list

* Show number of PIDs per org

* Fix HTML issue, sort orgs by title

* Try and fix the PID count

* Try and fix issues

* Try again to fix issues

* Try yet again to fix issues

* Correct the urlpart

* Change to sort_natural, minor code tidy

* Try and fix the sorting

* Try again to fix the sorting

* Remove debugging

* Add a link to orgs page

* Install dependencies for Travis

* Create .travis.yml

* Add the Travis script

* Update the Ruby version

* Bump the Ruby version some more

* Switch back to the documented version

* Add the exclude

* Update based on jekyll/jekyll#5413

* Add github-pages Gem

* Add missing gems

* Add redcarpet

* Switch to tasks so we can run multiple CI tasks

* Switch to tasks

* Fix the matrix

* More matrix fixing

* Turn on more htmlproofer options

* Make the check less strict

* Don't bother complaining about extra jekyll tags

* Escape HTML entities

* Fix the email link

* Fix the link within the 404 page!

* Escape more HTML entities

* Remove an invalid site URL

* Cache ruby bundles

* Escape even more HTML entities

* Escape yet more HTML entities

* Escape more HTML entities and switch to a div

* Try and fix the errant paragraph item

* Add a Travis badge to the readme

* Update Gemfile

Adapted from https://github.com/lunaryorn/lunaryorn.github.io

* Update _config.yml

* Add some more checks to Travis

* Report GH Pages versions

* Tidy up, add redcarpet back in

* Try and stop the spurious paragraph tags

* Check Open Graph

* Make pid.codes an internal domain

* Ensure we've got the fixed html-proofer

Arachnid added a commit to pidcodes/pidcodes.github.com that referenced this pull request Dec 1, 2016

Use the original orgpath URL (#198)
* Remove errant .DS_Store file

* Ignore .DS_Store

* Create a list of organisations

* Add an org list

* Show number of PIDs per org

* Fix HTML issue, sort orgs by title

* Try and fix the PID count

* Try and fix issues

* Try again to fix issues

* Try yet again to fix issues

* Correct the urlpart

* Change to sort_natural, minor code tidy

* Try and fix the sorting

* Try again to fix the sorting

* Remove debugging

* Add a link to orgs page

* Install dependencies for Travis

* Create .travis.yml

* Add the Travis script

* Update the Ruby version

* Bump the Ruby version some more

* Switch back to the documented version

* Add the exclude

* Update based on jekyll/jekyll#5413

* Add github-pages Gem

* Add missing gems

* Add redcarpet

* Switch to tasks so we can run multiple CI tasks

* Switch to tasks

* Fix the matrix

* More matrix fixing

* Turn on more htmlproofer options

* Make the check less strict

* Don't bother complaining about extra jekyll tags

* Escape HTML entities

* Fix the email link

* Fix the link within the 404 page!

* Escape more HTML entities

* Remove an invalid site URL

* Cache ruby bundles

* Escape even more HTML entities

* Escape yet more HTML entities

* Escape more HTML entities and switch to a div

* Try and fix the errant paragraph item

* Add a Travis badge to the readme

* Update Gemfile

Adapted from https://github.com/lunaryorn/lunaryorn.github.io

* Update _config.yml

* Add some more checks to Travis

* Report GH Pages versions

* Tidy up, add redcarpet back in

* Try and stop the spurious paragraph tags

* Check Open Graph

* Make pid.codes an internal domain

* Ensure we've got the fixed html-proofer

* Use the original orgpath URL

Arachnid added a commit to pidcodes/pidcodes.github.com that referenced this pull request Jan 9, 2017

Ignore the existing broken URLs (#200)
* Remove errant .DS_Store file

* Ignore .DS_Store

* Create a list of organisations

* Add an org list

* Show number of PIDs per org

* Fix HTML issue, sort orgs by title

* Try and fix the PID count

* Try and fix issues

* Try again to fix issues

* Try yet again to fix issues

* Correct the urlpart

* Change to sort_natural, minor code tidy

* Try and fix the sorting

* Try again to fix the sorting

* Remove debugging

* Add a link to orgs page

* Install dependencies for Travis

* Create .travis.yml

* Add the Travis script

* Update the Ruby version

* Bump the Ruby version some more

* Switch back to the documented version

* Add the exclude

* Update based on jekyll/jekyll#5413

* Add github-pages Gem

* Add missing gems

* Add redcarpet

* Switch to tasks so we can run multiple CI tasks

* Switch to tasks

* Fix the matrix

* More matrix fixing

* Turn on more htmlproofer options

* Make the check less strict

* Don't bother complaining about extra jekyll tags

* Escape HTML entities

* Fix the email link

* Fix the link within the 404 page!

* Escape more HTML entities

* Remove an invalid site URL

* Cache ruby bundles

* Escape even more HTML entities

* Escape yet more HTML entities

* Escape more HTML entities and switch to a div

* Try and fix the errant paragraph item

* Add a Travis badge to the readme

* Update Gemfile

Adapted from https://github.com/lunaryorn/lunaryorn.github.io

* Update _config.yml

* Add some more checks to Travis

* Report GH Pages versions

* Tidy up, add redcarpet back in

* Try and stop the spurious paragraph tags

* Check Open Graph

* Make pid.codes an internal domain

* Ensure we've got the fixed html-proofer

* Use the original orgpath URL

* Ignore some broken URLs

* Try and fix the syntax issue

* Third try at fixing syntax

* Ignore another broken URL

* Alternative ignore of a specific URL

* Ignore the remaining URLs

* Update Instant Infrastructure URL

* Remove a redundant URL ignore

* Update some broken links

* Update links

* Remove more resolved links

* Force links in kramdown

* Format more links for kramdown

* Make more links clickable/add more site URLs

* Fix more URLs

* Fix some more URLs and ignore some others

* Fix the remaining broken link

* Fix the URL I missed

Arachnid added a commit to pidcodes/pidcodes.github.com that referenced this pull request Mar 22, 2017

Try making liquid strict (#232)
* Remove errant .DS_Store file

* Ignore .DS_Store

* Create a list of organisations

* Add an org list

* Show number of PIDs per org

* Fix HTML issue, sort orgs by title

* Try and fix the PID count

* Try and fix issues

* Try again to fix issues

* Try yet again to fix issues

* Correct the urlpart

* Change to sort_natural, minor code tidy

* Try and fix the sorting

* Try again to fix the sorting

* Remove debugging

* Add a link to orgs page

* Install dependencies for Travis

* Create .travis.yml

* Add the Travis script

* Update the Ruby version

* Bump the Ruby version some more

* Switch back to the documented version

* Add the exclude

* Update based on jekyll/jekyll#5413

* Add github-pages Gem

* Add missing gems

* Add redcarpet

* Switch to tasks so we can run multiple CI tasks

* Switch to tasks

* Fix the matrix

* More matrix fixing

* Turn on more htmlproofer options

* Make the check less strict

* Don't bother complaining about extra jekyll tags

* Escape HTML entities

* Fix the email link

* Fix the link within the 404 page!

* Escape more HTML entities

* Remove an invalid site URL

* Cache ruby bundles

* Escape even more HTML entities

* Escape yet more HTML entities

* Escape more HTML entities and switch to a div

* Try and fix the errant paragraph item

* Add a Travis badge to the readme

* Update Gemfile

Adapted from https://github.com/lunaryorn/lunaryorn.github.io

* Update _config.yml

* Add some more checks to Travis

* Report GH Pages versions

* Tidy up, add redcarpet back in

* Try and stop the spurious paragraph tags

* Check Open Graph

* Make pid.codes an internal domain

* Ensure we've got the fixed html-proofer

* Use the original orgpath URL

* Ignore some broken URLs

* Try and fix the syntax issue

* Third try at fixing syntax

* Ignore another broken URL

* Alternative ignore of a specific URL

* Ignore the remaining URLs

* Update Instant Infrastructure URL

* Remove a redundant URL ignore

* Update some broken links

* Update links

* Remove more resolved links

* Force links in kramdown

* Format more links for kramdown

* Make more links clickable/add more site URLs

* Fix more URLs

* Fix some more URLs and ignore some others

* Fix the remaining broken link

* Fix the URL I missed

* Make Jekyll liquid processing strict, make general Jekyll processing verbose

* Try and fix the Liquid warning

* Try and fix more Liquid errors

* Fix more Liquid errors

* Switch to warn until we've fixed all the errors

* Switch back, warn doesn't actually log the errors :(

* Fix another error

* Revert and try another fix as it just breaks it

* Go verbose

* Revert and try another fix

* Revert and fix

* Assign and fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment